From: Linus Torvalds <torvalds@linux-foundation.org>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Witold Baryluk <baryluk@smp.if.uj.edu.pl>,
Alasdair G Kergon <agk@redhat.com>, Neil Brown <neilb@suse.de>,
linux-raid@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [dm-devel] Error when compiling drivers/md/dm-bufio.c
Date: Mon, 7 Nov 2011 08:18:13 -0800 [thread overview]
Message-ID: <CA+55aFwejLwfY6A9o2yx1YPJMD4a5grD6ttmoG1AsFdEcGZWcw@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1111071035380.5814@hs20-bc2-1.build.redhat.com>
On Mon, Nov 7, 2011 at 7:36 AM, Mikulas Patocka <mpatocka@redhat.com> wrote:
>
> Yes, apply this patch:
>
> dm-bufio: Include <linux/module.h>
Actually, is just <linux/export.h> sufficient?
It's much better to use just export.h if you have the choice - lots of
code doesn't need the whole module thing that brings in just about all
the headers in the whole kernel (ok, not quite, but still..)
That was kind of the whole point of the split.
Linus
next prev parent reply other threads:[~2011-11-07 16:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 8:22 Error when compiling drivers/md/dm-bufio.c Witold Baryluk
2011-11-07 13:46 ` [dm-devel] " Alasdair G Kergon
2011-11-07 15:36 ` Mikulas Patocka
2011-11-07 16:15 ` Witold Baryluk
2011-11-07 16:20 ` Alasdair G Kergon
2011-11-07 16:18 ` Linus Torvalds [this message]
2011-11-07 16:23 ` Mikulas Patocka
2011-11-07 16:32 ` Witold Baryluk
2011-11-07 19:00 ` Alasdair G Kergon
2011-11-07 20:27 ` [dm-devel] " Witold Baryluk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFwejLwfY6A9o2yx1YPJMD4a5grD6ttmoG1AsFdEcGZWcw@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=agk@redhat.com \
--cc=baryluk@smp.if.uj.edu.pl \
--cc=dm-devel@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).