From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH] dm raid: don't use 'const' in function return Date: Thu, 1 Feb 2018 10:24:22 +0100 Message-ID: References: <20160616090359.984712-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20160616090359.984712-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: Mike Snitzer , Alasdair Kergon , dm-devel@redhat.com, Shaohua Li , Heinz Mauelshagen , linux-raid@vger.kernel.org, Linux Kernel Mailing List List-Id: linux-raid.ids On Thu, Jun 16, 2016 at 11:03 AM, Arnd Bergmann wrote: > A newly introduced function has 'const int' as the return type, > but as "make W=1" reports, that has no meaning: > > drivers/md/dm-raid.c:510:18: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers] > > This changes the return type to plain 'int'. > > Signed-off-by: Arnd Bergmann > Fixes: 33e53f06850f ("dm raid: introduce extended superblock and new raid types to support takeover/reshaping") Acked-by: Geert Uytterhoeven The same issue has been reintroduced. So please reapply commit 68c1c4d5eafc65dd ("dm raid: don't use 'const' in function return") with Fixes: 552aa679f2657431 ("dm raid: use rs_is_raid*()") > index 96bcff7a0b94..55d25ac87bda 100644 > --- a/drivers/md/dm-raid.c > +++ b/drivers/md/dm-raid.c > @@ -507,7 +507,7 @@ static const char *raid10_md_layout_to_format(int layout) > } > > /* Return md raid10 algorithm for @name */ > -static const int raid10_name_to_format(const char *name) > +static int raid10_name_to_format(const char *name) > { > if (!strcasecmp(name, "near")) > return ALGORITHM_RAID10_NEAR; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds