From: Shaohua Li <shli@kernel.org>
To: Holger Kiehl <Holger.Kiehl@dwd.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"neilb@suse.de" <neilb@suse.de>,
"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [patch 0/7] Add TRIM support for raid linear/0/1/10
Date: Thu, 15 Mar 2012 10:39:44 +0800 [thread overview]
Message-ID: <CANejiEX=-y6Kgtmfg1efqn_Ufdnn=Ls-4Nne3RYAWdt07+4o2A@mail.gmail.com> (raw)
In-Reply-To: <alpine.LRH.2.02.1203142101290.6232@diagnostix.dwd.de>
2012/3/15 Holger Kiehl <Holger.Kiehl@dwd.de>:
> On Wed, 14 Mar 2012, Shaohua Li wrote:
>
>> Maybe the discard runs slow with small size request in the disk.
>> please drop patch "blk: add plug for blkdev_issue_discard" and try again.
>> Since
>> we can't do merge, the plug just introduces latency.
>>
> Tried again without the patch applied, but there is only a very small
> performance increase (520->600 agains 4000 fps without discard).
>
> The benchmark creates lots of small files (2 KiB) and deletes them again.
>
>
>> if it doesn't help, please capture a blktrace when you do the benchmark
>> and
>> send it to me.
>>
> Ok, I will do this tomorrow. Need some sleep :-)
>
> Thanks for your work on supporting discard in MD!
I tried your benchmark, create 2000k 2k files and delete them and
follows a sync.
the discard runs pretty fast for both raid 0/1. So can't reproduce the
issue. I'm using
a fusionio card though. I'm afraid nothing I can do till get you blktrace.
Thanks,
Shaohua
next prev parent reply other threads:[~2012-03-15 2:39 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 3:04 [patch 0/7] Add TRIM support for raid linear/0/1/10 Shaohua Li
2012-03-12 3:04 ` [patch 1/7] block: makes bio_split support bio without data Shaohua Li
2012-03-12 3:04 ` [patch 2/7] md: linear supports TRIM Shaohua Li
2012-03-12 3:04 ` [patch 3/7] md: raid 0 " Shaohua Li
2012-03-12 3:04 ` [patch 4/7] md: raid 1 " Shaohua Li
2012-03-12 3:04 ` [patch 5/7] md: raid 10 " Shaohua Li
2012-03-12 3:04 ` [patch 6/7] blk: add plug for blkdev_issue_discard Shaohua Li
2012-03-13 15:51 ` Vivek Goyal
2012-03-13 17:04 ` Martin K. Petersen
2012-03-13 17:14 ` Vivek Goyal
2012-03-13 17:19 ` Martin K. Petersen
2012-03-12 3:04 ` [patch 7/7] blk: use correct sectors limitation for discard request Shaohua Li
2012-03-13 16:00 ` Vivek Goyal
2012-03-12 3:18 ` [patch 0/7] Add TRIM support for raid linear/0/1/10 Roberto Spadim
2012-03-12 18:22 ` Holger Kiehl
[not found] ` <4F5EFEB6.4060402@kernel.org>
2012-03-13 12:22 ` Holger Kiehl
2012-03-13 14:15 ` Shaohua Li
2012-03-13 14:58 ` Roberto Spadim
2012-03-13 15:44 ` Holger Kiehl
2012-03-14 1:30 ` Shaohua Li
2012-03-14 10:25 ` Holger Kiehl
2012-03-14 11:14 ` Shaohua Li
2012-03-14 11:32 ` Shaohua Li
2012-03-14 21:01 ` Holger Kiehl
2012-03-14 21:13 ` Holger Kiehl
2012-03-15 2:39 ` Shaohua Li [this message]
2012-03-15 9:08 ` Holger Kiehl
2012-03-16 2:19 ` Shaohua Li
[not found] ` <4F5EA8E9.5010502@fusionio.com>
2012-03-14 2:25 ` NeilBrown
2012-03-14 2:24 ` NeilBrown
2012-03-14 2:47 ` Shaohua Li
2012-03-17 18:14 ` Mark Lord
2012-03-18 2:03 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANejiEX=-y6Kgtmfg1efqn_Ufdnn=Ls-4Nne3RYAWdt07+4o2A@mail.gmail.com' \
--to=shli@kernel.org \
--cc=Holger.Kiehl@dwd.de \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).