From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Williams Subject: Re: [PATCH v2 00/12] blk-integrity lifetime fixes Date: Thu, 15 Oct 2015 17:06:29 -0700 Message-ID: References: <20151015195939.20721.23101.stgit@dwillia2-desk3.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-raid-owner@vger.kernel.org To: "Martin K. Petersen" Cc: Jens Axboe , Keith Busch , linux-raid , Mike Snitzer , linux-nvdimm , Jens Axboe , Vishal Verma , James Bottomley , NeilBrown , linux-nvme@lists.infradead.org, Sagi Grimberg , dm-devel@redhat.com, Matthew Wilcox , Ross Zwisler , Christoph Hellwig List-Id: linux-raid.ids On Thu, Oct 15, 2015 at 4:53 PM, Martin K. Petersen wrote: >>>>>> "Dan" == Dan Williams writes: > > Dan, > > Dan> 5/ Fixed up Documentation/ABI/testing/sysfs-block to reflect moving > Dan> "integrity" sysfs attributes from "disk" to "disk/queue". > > You can't change an exported interface. Several apps are depending on > it. Hmm, add an "integrity" sysfs link for backwards compatibility, or leave it as a child of the gendisk kobject? Probably the latter because it seems fine if the integrity_kobj has follow the gendisk lifetime even if the struct blk_integrity info follows the request_queue.