From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C53D6C55178 for ; Sat, 7 Nov 2020 00:17:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64A162087E for ; Sat, 7 Nov 2020 00:17:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604708269; bh=w9AHeUgsbS21qz/kGcH7wQrUOhCa3nGk39KYZmKBWBU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=WEZlAsp3oQurYWW7jU16987YaeAshpo4pYQXUtX1oLUrQBqESWp65KpeTxkokX6ek HR8l4glhaXvhHckkvD49uyui9FMgTMPuOjcpeYK1fzlTcpi1ed/kQ1vfrWVvyQB9wX /HfarAAagESyi56WV5h3vyUQe/dtcpKd/nFOeMGU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728130AbgKGARs (ORCPT ); Fri, 6 Nov 2020 19:17:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:39238 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726987AbgKGARs (ORCPT ); Fri, 6 Nov 2020 19:17:48 -0500 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7680D2087E for ; Sat, 7 Nov 2020 00:17:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604708267; bh=w9AHeUgsbS21qz/kGcH7wQrUOhCa3nGk39KYZmKBWBU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=wpLfaLJCPHhfvLyvVJOY5FkVhxwxJTrUV+TtfvIYyph6I4ScJ98CUgGImlbf/cZB5 sRzCzXpVS0j9rofnkqEl8O0nmiNg2Vlo4Uj8UV9s94Nas+06PB8rqHjg6qNgA4mkNa qV+Eti+KT/1ytLLE15kVhuye9/L9+/YQfeLsr/jY= Received: by mail-lj1-f175.google.com with SMTP id y25so2408204lja.9 for ; Fri, 06 Nov 2020 16:17:47 -0800 (PST) X-Gm-Message-State: AOAM533hVJxJ2zwFy01k9ya18FVM0PEkttijEnczmhAYloe0tLJkUCb2 hgPNxcDkHmeWuDd7+XrNBgMHWHCLrxOz0iWdxdE= X-Google-Smtp-Source: ABdhPJziaqEfNV66C+cLVUgINMAMRoZt2wdxkqIlyo0FDbmHOKHjVQw3rdeafRh/fdcCok345SlIY/mPZ+nxJFVSdjw= X-Received: by 2002:a2e:6d09:: with SMTP id i9mr1707330ljc.10.1604708263677; Fri, 06 Nov 2020 16:17:43 -0800 (PST) MIME-Version: 1.0 References: <1604581888-27659-1-git-send-email-heming.zhao@suse.com> In-Reply-To: <1604581888-27659-1-git-send-email-heming.zhao@suse.com> From: Song Liu Date: Fri, 6 Nov 2020 16:17:32 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] md/cluster: reshape should returns error when remote doing resyncing job To: Zhao Heming Cc: linux-raid , Guoqing Jiang , lidong.zhong@suse.com, Xiao Ni , NeilBrown , Coly Li Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org On Thu, Nov 5, 2020 at 5:11 AM Zhao Heming wrote: > > Test script (reproducible steps): > ``` > ssh root@node2 "mdadm -S --scan" > mdadm -S --scan > mdadm --zero-superblock /dev/sd{g,h,i} > for i in {g,h,i};do dd if=/dev/zero of=/dev/sd$i oflag=direct bs=1M \ > count=20; done > > echo "mdadm create array" > mdadm -C /dev/md0 -b clustered -e 1.2 -n 2 -l mirror /dev/sdg /dev/sdh > echo "set up array on node2" > ssh root@node2 "mdadm -A /dev/md0 /dev/sdg /dev/sdh" > > sleep 5 > > mdadm --manage --add /dev/md0 /dev/sdi > mdadm --wait /dev/md0 > mdadm --grow --raid-devices=3 /dev/md0 > > mdadm /dev/md0 --fail /dev/sdg > mdadm /dev/md0 --remove /dev/sdg > #mdadm --wait /dev/md0 > mdadm --grow --raid-devices=2 /dev/md0 > ``` I found it was hard for me to follow this set. IIUC, the two patches try to address one issue. Please add a cover letter and reorganize the descriptions like: cover-letter: error behavior, repro steps, analysis, and maybe describe the relationship of the two patches. 1/2 and 2/2: what is being fixed. Thanks, Song [...]