From: Song Liu <song@kernel.org>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: xni@redhat.com, agk@redhat.com, snitzer@kernel.org,
dm-devel@redhat.com, linux-kernel@vger.kernel.org,
linux-raid@vger.kernel.org, yukuai3@huawei.com,
yi.zhang@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH -next v3 01/25] md: use READ_ONCE/WRITE_ONCE for 'suspend_lo' and 'suspend_hi'
Date: Thu, 28 Sep 2023 08:54:02 -0700 [thread overview]
Message-ID: <CAPhsuW7-Kq_bFpXtDUpiWtmBTFajewv=Uv4_GZR4zcoB9m1dBg@mail.gmail.com> (raw)
In-Reply-To: <20230928061543.1845742-2-yukuai1@huaweicloud.com>
On Wed, Sep 27, 2023 at 11:22 PM Yu Kuai <yukuai1@huaweicloud.com> wrote:
>
> From: Yu Kuai <yukuai3@huawei.com>
>
> Because reading 'suspend_lo' and 'suspend_hi' from md_handle_request()
> is not protected, use READ_ONCE/WRITE_ONCE to prevent reading abnormal
> value.
I rephrase this a bit:
Protect 'suspend_lo' and 'suspend_hi' with READ_ONCE/WRITE_ONCE to prevent
reading abnormal values.
Thanks,
Song
next prev parent reply other threads:[~2023-09-28 15:54 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 6:15 [PATCH -next v3 00/25] md: synchronize io with array reconfiguration Yu Kuai
2023-09-28 6:15 ` [PATCH -next v3 01/25] md: use READ_ONCE/WRITE_ONCE for 'suspend_lo' and 'suspend_hi' Yu Kuai
2023-09-28 15:54 ` Song Liu [this message]
2023-09-28 6:15 ` [PATCH -next v3 02/25] md: replace is_md_suspended() with 'mddev->suspended' in md_check_recovery() Yu Kuai
2023-09-28 6:15 ` [PATCH -next v3 03/25] md: add new helpers to suspend/resume array Yu Kuai
2023-09-28 18:45 ` Song Liu
[not found] ` <0ae441ba-68db-b823-b48c-76e953d22067@huaweicloud.com>
2023-10-05 4:00 ` Song Liu
2023-09-28 6:15 ` [PATCH -next v3 04/25] md: add new helpers to suspend/resume and lock/unlock array Yu Kuai
2023-09-28 6:15 ` [PATCH -next v3 05/25] md: use new apis to suspend array for suspend_lo/hi_store() Yu Kuai
2023-09-28 6:15 ` [PATCH -next v3 06/25] md: use new apis to suspend array for level_store() Yu Kuai
2023-09-28 6:15 ` [PATCH -next v3 07/25] md: use new apis to suspend array for serialize_policy_store() Yu Kuai
2023-09-28 6:15 ` [PATCH -next v3 08/25] md/dm-raid: use new apis to suspend array Yu Kuai
2023-09-28 6:15 ` [PATCH -next v3 09/25] md/md-bitmap: use new apis to suspend array for location_store() Yu Kuai
2023-09-28 6:15 ` [PATCH -next v3 10/25] md/raid5-cache: use READ_ONCE/WRITE_ONCE for 'conf->log' Yu Kuai
2023-09-28 6:15 ` [PATCH -next v3 11/25] md/raid5-cache: use new apis to suspend array for r5c_disable_writeback_async() Yu Kuai
2023-09-28 6:15 ` [PATCH -next v3 12/25] md/raid5-cache: use new apis to suspend array for r5c_journal_mode_store() Yu Kuai
2023-09-28 6:15 ` [PATCH -next v3 13/25] md/raid5: use new apis to suspend array for raid5_store_stripe_size() Yu Kuai
2023-09-28 6:15 ` [PATCH -next v3 14/25] md/raid5: use new apis to suspend array for raid5_store_skip_copy() Yu Kuai
2023-09-28 6:15 ` [PATCH -next v3 15/25] md/raid5: use new apis to suspend array for raid5_store_group_thread_cnt() Yu Kuai
2023-09-28 6:15 ` [PATCH -next v3 16/25] md/raid5: use new apis to suspend array for raid5_change_consistency_policy() Yu Kuai
2023-09-28 6:15 ` [PATCH -next v3 17/25] md/raid5: replace suspend with quiesce() callback Yu Kuai
2023-09-28 6:15 ` [PATCH -next v3 18/25] md: use new apis to suspend array for ioctls involed array reconfiguration Yu Kuai
2023-09-28 6:15 ` [PATCH -next v3 19/25] md: use new apis to suspend array for adding/removing rdev from state_store() Yu Kuai
2023-09-28 6:15 ` [PATCH -next v3 20/25] md: use new apis to suspend array before mddev_create/destroy_serial_pool Yu Kuai
2023-09-28 6:15 ` [PATCH -next v3 21/25] md: cleanup mddev_create/destroy_serial_pool() Yu Kuai
2023-09-28 6:15 ` [PATCH -next v3 22/25] md/md-linear: cleanup linear_add() Yu Kuai
2023-09-28 6:15 ` [PATCH -next v3 23/25] md: suspend array in md_start_sync() if array need reconfiguration Yu Kuai
2023-09-28 6:15 ` [PATCH -next v3 24/25] md: remove old apis to suspend the array Yu Kuai
2023-09-28 6:15 ` [PATCH -next v3 25/25] md: rename __mddev_suspend/resume() back to mddev_suspend/resume() Yu Kuai
2023-09-28 19:15 ` [PATCH -next v3 00/25] md: synchronize io with array reconfiguration Song Liu
[not found] ` <f59cbb99-33dd-c427-2e43-5a07ab9fbf51@huaweicloud.com>
2023-10-05 3:55 ` Song Liu
2023-10-07 2:32 ` Yu Kuai
2023-10-07 2:40 ` Song Liu
2023-10-07 2:49 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPhsuW7-Kq_bFpXtDUpiWtmBTFajewv=Uv4_GZR4zcoB9m1dBg@mail.gmail.com' \
--to=song@kernel.org \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=snitzer@kernel.org \
--cc=xni@redhat.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).