From: Song Liu <song@kernel.org>
To: "Dirk Müller" <dmueller@suse.de>
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] lib/raid6: skip benchmark of non-chosen xor_syndrome functions
Date: Wed, 5 Jan 2022 10:55:22 -0800 [thread overview]
Message-ID: <CAPhsuW7i2NxkOTBdtzeXXXGRGWkmDAUswudBBmo80oZmgorG5w@mail.gmail.com> (raw)
In-Reply-To: <20220105163847.18592-1-dmueller@suse.de>
On Wed, Jan 5, 2022 at 8:39 AM Dirk Müller <dmueller@suse.de> wrote:
>
> In commit fe5cbc6e06c7 ("md/raid6 algorithms: delta syndrome functions")
> a xor_syndrome() benchmarking was added also to the raid6_choose_gen()
> function. However, the results of that benchmarking were intentionally
> discarded and did not influence the choice. It picked the
> xor_syndrome() variant related to the best performing gen_syndrome().
>
> Reduce runtime of raid6_choose_gen() without modifying its outcome by
> only benchmarking the xor_syndrome() of the best gen_syndrome() variant.
>
> For a HZ=250 x86_64 system with avx2 and without avx512 this removes
> 5 out of 6 xor() benchmarks, saving 340ms of raid6 initialization time.
>
> Signed-off-by: Dirk Müller <dmueller@suse.de>
Applied both patches to md-next.
Thanks,
Song
prev parent reply other threads:[~2022-01-05 18:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 16:38 [PATCH v2 1/2] lib/raid6: skip benchmark of non-chosen xor_syndrome functions Dirk Müller
2022-01-05 16:38 ` [PATCH v2 2/2] lib/raid6: Use strict priority ranking for pq gen() benchmarking Dirk Müller
2022-01-05 18:55 ` Song Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPhsuW7i2NxkOTBdtzeXXXGRGWkmDAUswudBBmo80oZmgorG5w@mail.gmail.com \
--to=song@kernel.org \
--cc=dmueller@suse.de \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).