linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] md -  Resolve problem with refcounting of md arrays.
@ 2003-07-28  6:56 NeilBrown
  0 siblings, 0 replies; only message in thread
From: NeilBrown @ 2003-07-28  6:56 UTC (permalink / raw)
  To: Marcelo Tosatti; +Cc: linux-raid


Because an md array may not exist yet when the device it opened, the ->active
count, which is incremented on opening if the array exists, is not 100% reliable.
This patch changes md to test inode->i_bdev->bd_openers rather than mddev->active
to test if an array is still in used before stopping it.

(patch against 2.4.22-pre9)

diff ./drivers/md/md.c~current~ ./drivers/md/md.c
--- ./drivers/md/md.c~current~	2003-07-28 16:24:11.000000000 +1000
+++ ./drivers/md/md.c	2003-07-28 16:26:48.000000000 +1000
@@ -1805,10 +1805,12 @@ static int do_md_stop(mddev_t * mddev, i
 	int err = 0, resync_interrupted = 0;
 	kdev_t dev = mddev_to_kdev(mddev);
 
+#if 0 /* ->active is not currently reliable */
 	if (atomic_read(&mddev->active)>1) {
 		printk(STILL_IN_USE, mdidx(mddev));
 		OUT(-EBUSY);
 	}
+#endif
 
 	if (mddev->pers) {
 		/*
@@ -2742,12 +2744,17 @@ static int md_ioctl(struct inode *inode,
 			goto done_unlock;
 
 		case STOP_ARRAY:
-			if (!(err = do_md_stop (mddev, 0)))
+			if (inode->i_bdev->bd_openers > 1)
+				err = -EBUSY;
+			else if (!(err = do_md_stop (mddev, 0)))
 				mddev = NULL;
 			goto done_unlock;
 
 		case STOP_ARRAY_RO:
-			err = do_md_stop (mddev, 1);
+			if (inode->i_bdev->bd_openers > 1)
+				err = -EBUSY;
+			else 
+				err = do_md_stop (mddev, 1);
 			goto done_unlock;
 
 	/*

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-07-28  6:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-07-28  6:56 [PATCH] md - Resolve problem with refcounting of md arrays NeilBrown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).