From: NeilBrown <neilb@cse.unsw.edu.au>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-raid@vger.kernel.org
Subject: [PATCH] md - 6 of 10 - Don't do_md_stop and array when do_md_run fails.
Date: Fri, 16 Jan 2004 12:19:39 +1100 [thread overview]
Message-ID: <E1AhIeB-0002Uc-00@notabene> (raw)
Current code calls do_md_stop to clean up if do_md_run
fails, but this is
a/ not needed as do_md_run cleans up itself
b/ bad as it could try to clean up after an -EBUSY error !!!
----------- Diffstat output ------------
./drivers/md/md.c | 15 +--------------
1 files changed, 1 insertion(+), 14 deletions(-)
diff ./drivers/md/md.c~current~ ./drivers/md/md.c
--- ./drivers/md/md.c~current~ 2004-01-16 12:05:40.000000000 +1100
+++ ./drivers/md/md.c 2004-01-16 12:06:25.000000000 +1100
@@ -1764,10 +1764,8 @@ static void autorun_array(mddev_t *mddev
printk("\n");
err = do_md_run (mddev);
- if (err) {
+ if (err)
printk(KERN_WARNING "md :do_md_run() returned %d\n", err);
- do_md_stop (mddev, 0);
- }
}
/*
@@ -2569,19 +2567,8 @@ static int md_ioctl(struct inode *inode,
goto done_unlock;
case RUN_ARRAY:
- {
err = do_md_run (mddev);
- /*
- * we have to clean up the mess if
- * the array cannot be run for some
- * reason ...
- * ->pers will not be set, to superblock will
- * not be updated.
- */
- if (err)
- do_md_stop (mddev, 0);
goto done_unlock;
- }
default:
if (_IOC_TYPE(cmd) == MD_MAJOR)
reply other threads:[~2004-01-16 1:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1AhIeB-0002Uc-00@notabene \
--to=neilb@cse.unsw.edu.au \
--cc=akpm@osdl.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).