From: NeilBrown <neilb@cse.unsw.edu.au>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-raid@vger.kernel.org
Subject: [PATCH] md - 10 of 10 - Use bd_disk->private data instead of bd_inode->u.generic_ip
Date: Fri, 16 Jan 2004 12:19:41 +1100 [thread overview]
Message-ID: <E1AhIeD-0002VC-00@notabene> (raw)
### Comments for ChangeSet
..to access 'mddev' from the inode pointer. This is already
set up for us.
----------- Diffstat output ------------
./drivers/md/md.c | 21 +++++++++------------
1 files changed, 9 insertions(+), 12 deletions(-)
diff ./drivers/md/md.c~current~ ./drivers/md/md.c
--- ./drivers/md/md.c~current~ 2004-01-16 12:08:10.000000000 +1100
+++ ./drivers/md/md.c 2004-01-16 12:08:45.000000000 +1100
@@ -2406,7 +2406,7 @@ static int md_ioctl(struct inode *inode,
* Commands creating/starting a new array:
*/
- mddev = inode->i_bdev->bd_inode->u.generic_ip;
+ mddev = inode->i_bdev->bd_disk->private_data;
if (!mddev) {
BUG();
@@ -2598,29 +2598,26 @@ abort:
static int md_open(struct inode *inode, struct file *file)
{
/*
- * Succeed if we can find or allocate a mddev structure.
+ * Succeed if we can lock the mddev, which confirms that
+ * it isn't being stopped right now.
*/
- mddev_t *mddev = mddev_find(iminor(inode));
- int err = -ENOMEM;
-
- if (!mddev)
- goto out;
+ mddev_t *mddev = inode->i_bdev->bd_disk->private_data;
+ int err;
if ((err = mddev_lock(mddev)))
- goto put;
+ goto out;
err = 0;
+ mddev_get(mddev);
mddev_unlock(mddev);
- inode->i_bdev->bd_inode->u.generic_ip = mddev_get(mddev);
- put:
- mddev_put(mddev);
+
out:
return err;
}
static int md_release(struct inode *inode, struct file * file)
{
- mddev_t *mddev = inode->i_bdev->bd_inode->u.generic_ip;
+ mddev_t *mddev = inode->i_bdev->bd_disk->private_data;
if (!mddev)
BUG();
reply other threads:[~2004-01-16 1:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1AhIeD-0002VC-00@notabene \
--to=neilb@cse.unsw.edu.au \
--cc=akpm@osdl.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).