From: wsy@dogben.com
To: Song Liu <song@kernel.org>
Cc: linux-raid@vger.kernel.org,
Paul Clements <paul.clements@us.sios.com>,
Yufen Yu <yuyufen@huawei.com>
Subject: [PATCH] md/raid10: properly indicate failure when ending a failed write request
Date: Fri, 25 Jun 2021 02:27:09 +0800 [thread overview]
Message-ID: <E1lwU4E-0029Uw-MM@dogben.com> (raw)
Similar to commit 2417b9869b81882ab90fd5ed1081a1cb2d4db1dd, this patch
fixes the same bug in raid10.
Fixes: 7cee6d4e6035 ("md/raid10: end bio when the device faulty")
Signed-off-by: Wei Shuyu <wsy@dogben.com>
---
Maybe there are other bugs fixed in one but left open in the other?
drivers/md/raid10.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index 13f5e6b2a73d..f9c3b2323d7c 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -475,6 +475,8 @@ static void raid10_end_write_request(struct bio *bio)
if (!test_bit(Faulty, &rdev->flags))
set_bit(R10BIO_WriteError, &r10_bio->state);
else {
+ /* Fail the request */
+ set_bit(R10BIO_Degraded, &r10_bio->state);
r10_bio->devs[slot].bio = NULL;
to_put = bio;
dec_rdev = 1;
--
2.32.0
next reply other threads:[~2021-06-24 18:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 18:27 wsy [this message]
2021-06-25 1:58 ` [PATCH] md/raid10: properly indicate failure when ending a failed write request Guoqing Jiang
2021-06-25 3:03 ` Wei Shuyu
2021-06-25 3:14 ` Guoqing Jiang
2021-06-25 14:20 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1lwU4E-0029Uw-MM@dogben.com \
--to=wsy@dogben.com \
--cc=linux-raid@vger.kernel.org \
--cc=paul.clements@us.sios.com \
--cc=song@kernel.org \
--cc=yuyufen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox