public inbox for linux-raid@vger.kernel.org
 help / color / mirror / Atom feed
From: Song Liu <songliubraving@fb.com>
To: Shaohua Li <shli@fb.com>
Cc: "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
	Kernel Team <Kernel-team@fb.com>, NeilBrown <neilb@suse.com>
Subject: Re: [PATCH] raid5: only dispatch IO from raid5d for harddisk raid
Date: Wed, 4 Jan 2017 18:10:59 +0000	[thread overview]
Message-ID: <E6506DA7-E269-4092-8761-12FFC1770F82@fb.com> (raw)
In-Reply-To: <9e987c0d95c49224da7fb82477dd10fcacf4d794.1483552525.git.shli@fb.com>


> On Jan 4, 2017, at 9:57 AM, Shaohua Li <shli@fb.com> wrote:
> 
> +	spin_lock_init(&conf->pending_bios_lock);
> +	conf->batch_bio_dispatch = true;
> +	rdev_for_each(rdev, mddev) {
> +		if (blk_queue_nonrot(bdev_get_queue(rdev->bdev))) {
> +			conf->batch_bio_dispatch = false;

Shall we skip this check for the journal device? 

Song

  reply	other threads:[~2017-01-04 18:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-04 17:57 [PATCH] raid5: only dispatch IO from raid5d for harddisk raid Shaohua Li
2017-01-04 18:10 ` Song Liu [this message]
2017-01-04 18:14   ` Shaohua Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E6506DA7-E269-4092-8761-12FFC1770F82@fb.com \
    --to=songliubraving@fb.com \
    --cc=Kernel-team@fb.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.com \
    --cc=shli@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox