From: Christoph Hellwig <hch@infradead.org>
To: Guoqing Jiang <jgq516@gmail.com>
Cc: song@kernel.org, linux-raid@vger.kernel.org,
artur.paszkiewicz@intel.com,
Guoqing Jiang <jiangguoqing@kylinos.cn>
Subject: Re: [PATCH 2/5] md: the latest try for improve io stats accounting
Date: Tue, 18 May 2021 14:35:35 +0100 [thread overview]
Message-ID: <YKPCpwHbr/E9q31g@infradead.org> (raw)
In-Reply-To: <20210518053225.641506-3-jiangguoqing@kylinos.cn>
> + struct bio orig_bio_clone;
Maybe call this bio_clone? or just bio?
> +static void md_end_io(struct bio *bio)
> +{
> + struct md_io *md_io = bio->bi_private;
> + struct bio *orig_bio = md_io->orig_bio;
> +
> + orig_bio->bi_status = bio->bi_status;
> +
> + bio_end_io_acct_remapped(orig_bio, md_io->start_time, orig_bio->bi_bdev);
Overly long line. And trivially fixed by just using bio_end_io_acct.
> + /*
> + * We don't clone bio for multipath, raid1 and raid10 since we can reuse
> + * their clone infrastructure.
> + */
> + if (blk_queue_io_stat(bio->bi_bdev->bd_disk->queue) &&
> + (bio->bi_pool != &mddev->md_io_bs) &&
> + (mddev->level != 1) && (mddev->level != 10) &&
> + (mddev->level != LEVEL_MULTIPATH)) {
This should use a flag in struct md_personality instead.
> - if (bioset_integrity_create(&mddev->bio_set, BIO_POOL_SIZE)) {
> + if (bioset_integrity_create(&mddev->bio_set, BIO_POOL_SIZE) ||
> + bioset_integrity_create(&mddev->md_io_bs, BIO_POOL_SIZE)) {
If the md_io_bs creation fails bio_set needs to be cleaned up.
next prev parent reply other threads:[~2021-05-18 13:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 5:32 [PATCH 0/5] md: io stats accounting Guoqing Jiang
2021-05-18 5:32 ` [PATCH 1/5] md: revert " Guoqing Jiang
2021-05-18 5:32 ` [PATCH 2/5] md: the latest try for improve " Guoqing Jiang
2021-05-18 10:12 ` Artur Paszkiewicz
2021-05-19 1:30 ` Guoqing Jiang
2021-05-19 7:26 ` Artur Paszkiewicz
2021-05-19 7:46 ` Christoph Hellwig
2021-05-19 8:09 ` Guoqing Jiang
2021-05-20 0:45 ` Song Liu
2021-05-18 13:35 ` Christoph Hellwig [this message]
2021-05-19 1:40 ` Guoqing Jiang
2021-05-18 5:32 ` [PATCH 3/5] md-multipath: enable io accounting Guoqing Jiang
2021-05-18 13:37 ` Christoph Hellwig
2021-05-19 1:46 ` Guoqing Jiang
2021-05-18 5:32 ` [PATCH 4/5] md/raid1: " Guoqing Jiang
2021-05-18 13:40 ` Christoph Hellwig
2021-05-19 1:47 ` Guoqing Jiang
2021-05-18 5:32 ` [PATCH 5/5] md/raid10: " Guoqing Jiang
2021-05-19 0:14 ` [PATCH 0/5] md: io stats accounting Song Liu
2021-05-19 1:50 ` Guoqing Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKPCpwHbr/E9q31g@infradead.org \
--to=hch@infradead.org \
--cc=artur.paszkiewicz@intel.com \
--cc=jgq516@gmail.com \
--cc=jiangguoqing@kylinos.cn \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox