From: Christoph Hellwig <hch@infradead.org>
To: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Cc: Guoqing Jiang <jgq516@gmail.com>,
song@kernel.org, linux-raid@vger.kernel.org,
Guoqing Jiang <jiangguoqing@kylinos.cn>
Subject: Re: [PATCH 2/5] md: the latest try for improve io stats accounting
Date: Wed, 19 May 2021 08:46:00 +0100 [thread overview]
Message-ID: <YKTCOHp0rKmKcW2K@infradead.org> (raw)
In-Reply-To: <d788bc1f-3fd9-a293-2f2a-6047fdd45625@intel.com>
On Wed, May 19, 2021 at 09:26:21AM +0200, Artur Paszkiewicz wrote:
> On 19.05.2021 03:30, Guoqing Jiang wrote:
> > Hmm, raid0 allocates split bio from mddev->bio_set, but raid5 is
> > different, it splits bio from r5conf->bio_split. So either let raid5 also
> > splits bio from mddev->bio_set, or add an additional checking for
> > raid5. Thoughts?
>
> It looks like raid5 has a different bio set for that because it uses
> mddev->bio_set for something else - allocating a bio for rdev. So I
> think it can be changed to split from mddev->bio_set and have a private
> bio set for the rdev bio allocation.
Just wondering: what about moving the allocation of the clone into the
personalities entirely?
next prev parent reply other threads:[~2021-05-19 7:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 5:32 [PATCH 0/5] md: io stats accounting Guoqing Jiang
2021-05-18 5:32 ` [PATCH 1/5] md: revert " Guoqing Jiang
2021-05-18 5:32 ` [PATCH 2/5] md: the latest try for improve " Guoqing Jiang
2021-05-18 10:12 ` Artur Paszkiewicz
2021-05-19 1:30 ` Guoqing Jiang
2021-05-19 7:26 ` Artur Paszkiewicz
2021-05-19 7:46 ` Christoph Hellwig [this message]
2021-05-19 8:09 ` Guoqing Jiang
2021-05-20 0:45 ` Song Liu
2021-05-18 13:35 ` Christoph Hellwig
2021-05-19 1:40 ` Guoqing Jiang
2021-05-18 5:32 ` [PATCH 3/5] md-multipath: enable io accounting Guoqing Jiang
2021-05-18 13:37 ` Christoph Hellwig
2021-05-19 1:46 ` Guoqing Jiang
2021-05-18 5:32 ` [PATCH 4/5] md/raid1: " Guoqing Jiang
2021-05-18 13:40 ` Christoph Hellwig
2021-05-19 1:47 ` Guoqing Jiang
2021-05-18 5:32 ` [PATCH 5/5] md/raid10: " Guoqing Jiang
2021-05-19 0:14 ` [PATCH 0/5] md: io stats accounting Song Liu
2021-05-19 1:50 ` Guoqing Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKTCOHp0rKmKcW2K@infradead.org \
--to=hch@infradead.org \
--cc=artur.paszkiewicz@intel.com \
--cc=jgq516@gmail.com \
--cc=jiangguoqing@kylinos.cn \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox