From: Chris Webb <chris@arachsys.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Song Liu <song@kernel.org>, linux-raid@vger.kernel.org
Subject: Re: [PATCH] md: Explicitly create command-line configured devices
Date: Wed, 1 Jun 2022 11:52:17 +0100 [thread overview]
Message-ID: <YpdE4TZRY728hDNw@arachsys.com> (raw)
In-Reply-To: <YpYzhpZZwc1jY4D0@infradead.org>
Christoph Hellwig <hch@infradead.org> writes:
> On Tue, May 31, 2022 at 11:50:08AM +0100, Chris Webb wrote:
> > +extern int md_alloc(dev_t dev, char *name);
>
> No need for the extern here.
>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks! I'll resend with the redundant extern dropped.
Best wishes,
Chris.
prev parent reply other threads:[~2022-06-01 10:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 10:50 [PATCH] md: Explicitly create command-line configured devices Chris Webb
2022-05-31 15:25 ` Christoph Hellwig
2022-06-01 10:52 ` Chris Webb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpdE4TZRY728hDNw@arachsys.com \
--to=chris@arachsys.com \
--cc=hch@infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).