From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94369C7EE23 for ; Thu, 1 Jun 2023 04:26:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230509AbjFAE0j (ORCPT ); Thu, 1 Jun 2023 00:26:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229562AbjFAE0h (ORCPT ); Thu, 1 Jun 2023 00:26:37 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A65F123 for ; Wed, 31 May 2023 21:26:36 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1b041cceb16so3434315ad.2 for ; Wed, 31 May 2023 21:26:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20221208.gappssmtp.com; s=20221208; t=1685593596; x=1688185596; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HH54ZfR07bvx2it5kMbT2XCoKq4FYr76emvIl28NWxo=; b=XboIlDk6Glckt0sGHOtjbw6iiPKyy3vUg0ctkhF0OKTH2CIPL7wBwcdMMK9gWQNfX7 12wjr48MrbLmZPXhqx6s/hmcAY+vKX0027Sh8qUOS0Xh8BOpfAlEoIxdHBfNd5jzbEKw e+6pfHEO2OpXvwHCA7ZjasUfm8+D6I2fd2yZ6XLBxLVjLscZyucIUDh4Ydks3vK9XC4f TaiAk0Rbskf4ZlMxfrDHQaUqeeQUVXUJBTKxnxguxWjQMrGrbp8VWeZyIbzF40zH4YU3 9Zx+fWIQv0ERI7wQudqS9d1ttQ/nZcQWf9kOw8V0bB/EgKGKbGVx0zQOgtawjec2gHoC vSLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685593596; x=1688185596; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HH54ZfR07bvx2it5kMbT2XCoKq4FYr76emvIl28NWxo=; b=Hza3VbyEno2yPjCjoPNoaA17CKk3fQYS0+ZuUMYJP+votOrbeXwdrRM3p6KJ0Vc8PH fAM8daMxdfKgvoU+IOqzB1NcEc1CSV3Me3Yf5oXT2rb3kYxkwbGhqHXfMfZNheJ/tXP9 LriAehELpGBMCXY+dB6zEUqB6qVMf68nBtC/HHQIc/F489Ny02YgxstDz5LzG0vvozOp 9UtcHkYDrX8/OudWKiZG2x2gom1nH8idVCbaoVNt5nxjyC11F5O6phJGjkfGiRnugRwt hsxqqJYJS6N9mrOvnO4D5yal46l3sWVVpm4ktWFyGgNvIN+Vy65mD2bVI7gL1PHb5XNW pJGQ== X-Gm-Message-State: AC+VfDyKC1MV/RlvL/8cwaRjRgd0074XglB36mvZDl1CG1EoOO3R2sXI j2ULcFYI5BskfLkg7ypQUID/og== X-Google-Smtp-Source: ACHHUZ6hlZU/MsjoyVz4yyhoe997V/qcrYIwn3uWW59qEXQKN9Rt7VfRZ5XiA6hG1XPeblBFMsaoCQ== X-Received: by 2002:a17:902:724c:b0:1af:b9ed:1677 with SMTP id c12-20020a170902724c00b001afb9ed1677mr6568666pll.2.1685593595885; Wed, 31 May 2023 21:26:35 -0700 (PDT) Received: from dread.disaster.area (pa49-179-0-188.pa.nsw.optusnet.com.au. [49.179.0.188]) by smtp.gmail.com with ESMTPSA id f13-20020a170902684d00b001a980a23802sm2281781pln.111.2023.05.31.21.26.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 May 2023 21:26:34 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1q4ZtQ-006NBe-17; Thu, 01 Jun 2023 14:26:32 +1000 Date: Thu, 1 Jun 2023 14:26:32 +1000 From: Dave Chinner To: Christoph Hellwig Cc: Johannes Thumshirn , Jens Axboe , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , gouha7@uniontech.com Subject: Re: [PATCH v7 19/20] fs: iomap: use bio_add_folio_nofail where possible Message-ID: References: <58fa893c24c67340a63323f09a179fefdca07f2a.1685532726.git.johannes.thumshirn@wdc.com> <20230601042021.GA21768@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230601042021.GA21768@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org On Thu, Jun 01, 2023 at 06:20:21AM +0200, Christoph Hellwig wrote: > On Thu, Jun 01, 2023 at 08:36:59AM +1000, Dave Chinner wrote: > > We lose adjacent page merging with this change. > > This is only used for adding the first folio to a brand new bio, > so there is nothing to merge with yet at this point. Ah, sorry, missed that. Carry on. :) -Dave. -- Dave Chinner david@fromorbit.com