From: Christoph Hellwig <hch@infradead.org>
To: Jinyoung Choi <j-young.choi@samsung.com>
Cc: "song@kernel.org" <song@kernel.org>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"pmenzel@molgen.mpg.de" <pmenzel@molgen.mpg.de>
Subject: Re: [PATCH v2] md/bitmap: Avoid protection error writing bitmap page with block integrity
Date: Mon, 31 Jul 2023 00:26:09 -0700 [thread overview]
Message-ID: <ZMdiEavzzRwAFjPq@infradead.org> (raw)
In-Reply-To: <20230720092957epcms2p6cbd0ecdf7f5bf0db3c04eefaf0a6644d@epcms2p6>
On Thu, Jul 20, 2023 at 06:29:57PM +0900, Jinyoung Choi wrote:
> Changing the bitmap page is also possible on the page where the DMA is
> being performed or scheduled in the MD.
Are you guys actually using the whacky bitmap feature? If so, this
really is the least of our problems and you need to invest some real
work into it to get it off ->bmap and into using ->read_iter and
->write_iter. Right now Song has a series from me queued up to
deprecated it.
I also don't think a simple wait for existing writers prevents you
from other modifications, but maybe I'm issing something.
next prev parent reply other threads:[~2023-07-31 7:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230720092957epcms2p6cbd0ecdf7f5bf0db3c04eefaf0a6644d@epcms2p6>
2023-07-20 9:29 ` [PATCH v2] md/bitmap: Avoid protection error writing bitmap page with block integrity Jinyoung Choi
2023-07-31 7:26 ` Christoph Hellwig [this message]
2023-07-31 7:49 ` Jinyoung Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMdiEavzzRwAFjPq@infradead.org \
--to=hch@infradead.org \
--cc=j-young.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox