From: Luis Chamberlain <mcgrof@kernel.org>
To: Yu Kuai <yukuai1@huaweicloud.com>,
Joel Granados <j.granados@samsung.com>
Cc: Coly Li <colyli@suse.de>,
song@kernel.org, linux-raid@vger.kernel.org,
Joel Granados <j.granados@samsung.com>,
"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH] Revert "raid: Remove now superfluous sentinel element from ctl_table array"
Date: Thu, 21 Dec 2023 11:17:31 -0800 [thread overview]
Message-ID: <ZYSPS+yUlzTYETgh@bombadil.infradead.org> (raw)
In-Reply-To: <aef386e9-90b2-9847-89cd-1566a5969a08@huaweicloud.com>
On Thu, Dec 21, 2023 at 02:19:56PM +0800, Yu Kuai wrote:
> I can't find this by code review, and I think
> maybe it's better to fix this in sysctl error path.
Indeed, we want to fix anything in the way to remove the empty sentinel,
we continue to do that in queued work on sysctl-next [0]. Although I
won't be able to diagnose this right away, could you try the out of
bounds fix by Joel [1] instead?
We want to identify what caused this and fix it within sysctl code.
[0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=sysctl-next
[1] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/commit/?h=sysctl-next&id=fd696ee2395755a292f7d49bf4c701a5bab2f076
Luis
next prev parent reply other threads:[~2023-12-21 19:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 4:49 [PATCH] Revert "raid: Remove now superfluous sentinel element from ctl_table array" Coly Li
2023-12-21 6:19 ` Yu Kuai
2023-12-21 7:11 ` Coly Li
2023-12-21 19:17 ` Luis Chamberlain [this message]
2023-12-22 10:17 ` Coly Li
2023-12-22 17:31 ` Luis Chamberlain
2023-12-23 12:25 ` Joel Granados
2023-12-23 12:42 ` Coly Li
2023-12-23 12:58 ` Joel Granados
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYSPS+yUlzTYETgh@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=colyli@suse.de \
--cc=j.granados@samsung.com \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).