From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82D0F61FE8; Wed, 26 Jun 2024 03:39:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719373197; cv=none; b=r8lU6K0IVDQwqeDtwIHaq2MVFxdmscqKToyPbhTjN0ORvnQejCJisFpz8F0rUTai8G1MuR4+fj5Oar16oaiadBRy8F1eTs6paE8Kh4thwL7W+CXDUWRE0BQGwoKrKRDgGPp4B3+odwTMcGBkHXwUO/seQHzx3bQeIdACYGUEgC4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719373197; c=relaxed/simple; bh=3Sqem+lMn+S52efuvN21xdPnqe1u52xD6z7JDEdxua8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OKol9UXbZTbOWPXQZk1EPyVzbPBMeTyZvzDH7024sObyKuMqttJLzEuX8u+W3pSnPBwLnRurzoQYgZc2Fh5MjVC8ST6ylpjsda0Pbyr3CQFJ3kzOe/zRQNFSUvl9nsCVaFIx4RsxqAV3aIMYwwectaDCFWW4wLBtFxwnmgLG5bU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=v38aUgEx; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="v38aUgEx" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=q35hat2STPhlr4DAn4+ABXn/NxJWaK5wgb5DlM6xpCg=; b=v38aUgExch/0roE+EfRJ2Glql8 NJM5fN+YEIB1TYrzijSpWBKOBPz4ePJWBmxAeIq8Vy0dgCM+B8D7e2Uu/8N8Um6Vr/QojQ2rgIn5c kZ0Qn4LEY3fOdOmfyKwMWEDOh9Ymv1GdTyRuFBajkXiPOidtU70du4sEE9xKuUof+3qQcWAWRaj21 Q277QHf25k5Hs4ZG2a3z7KhsZxdHv16NmcJJI6IIXWv8/dTL6K+es5s2mnReHc51vjem7WfsNQ2Oh GFZANqqhPdUBbop3nLGkV+BdHz5dumNmTIDB8b0TUPLkhRAW/U3MN14I64qofM3LTvdEoRKFoAPJn ZHT0K0YA==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMJVe-00000005Ecx-3HCZ; Wed, 26 Jun 2024 03:39:50 +0000 Date: Tue, 25 Jun 2024 20:39:50 -0700 From: Christoph Hellwig To: Oliver Sang Cc: Christoph Hellwig , Christoph Hellwig , oe-lkp@lists.linux.dev, lkp@intel.com, Jens Axboe , Ulf Hansson , Damien Le Moal , Hannes Reinecke , linux-block@vger.kernel.org, linux-um@lists.infradead.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, dm-devel@lists.linux.dev, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com Subject: Re: [axboe-block:for-next] [block] 1122c0c1cc: aim7.jobs-per-min 22.6% improvement Message-ID: References: <202406250948.e0044f1d-oliver.sang@intel.com> Precedence: bulk X-Mailing-List: linux-raid@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Wed, Jun 26, 2024 at 10:10:49AM +0800, Oliver Sang wrote: > I'm not sure I understand this test request. as in title, we see a good > improvement of aim7 for 1122c0c1cc, and we didn't observe other issues for > this commit. The improvement suggests we are not sending cache flushes when we should send them, or at least just handle them in md. > do you mean this improvement is not expected or exposes some problems instead? > then by below patch, should the performance back to the level of parent of > 1122c0c1cc? > > sure! it's our great pleasure to test your patches. I noticed there are > [1] > https://lore.kernel.org/all/20240625110603.50885-2-hch@lst.de/ > which includes "[PATCH 1/7] md: set md-specific flags for all queue limits" > [2] > https://lore.kernel.org/all/20240625145955.115252-2-hch@lst.de/ > which includes "[PATCH 1/8] md: set md-specific flags for all queue limits" > > which one you suggest us to test? > do we only need to apply the first patch "md: set md-specific flags for all queue limits" > upon 1122c0c1cc? > then is the expectation the performance back to parent of 1122c0c1cc? Either just the patch in reply or the entire [2] series would be fine. Thanks!