Re: [PATCH]mdadm: fix coredump of mdadm --monitor -r

[Jes Sorensen <jes@trained-monkey.org>]

On 8/16/21 3:24 AM, Wu Guanghao wrote:
> Hi,
> 
> The --monitor -r option requires a parameter, otherwise a null pointer will be manipulated
> when converting to integer data, and a coredump will appear.
> 
> # mdadm --monitor -r
> Segmentation fault (core dumped)
> 
> Signed-off-by: Wu Guanghao <wuguanghao3@huawei.com>
> ---
>  ReadMe.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Something is fishy with your mail client as this didn't apply, but I
applied it manually.

This seems a reasonable fix, even though we have different usages of -r
they all require an argument. That said the whole argument parsing
handling could do with an overhaul.

Thanks,
Jes


> diff --git a/ReadMe.c b/ReadMe.c
> index 06b8f7e..070a164 100644
> --- a/ReadMe.c
> +++ b/ReadMe.c
> @@ -81,11 +81,11 @@ char Version[] = "mdadm - v" VERSION " - " VERS_DATE EXTRAVERSION "\n";
>   *     found, it is started.
>   */
> 
> -char short_options[]="-ABCDEFGIQhVXYWZ:vqbc:i:l:p:m:n:x:u:c:d:z:U:N:sarfRSow1tye:k:";
> +char short_options[]="-ABCDEFGIQhVXYWZ:vqbc:i:l:p:m:r:n:x:u:c:d:z:U:N:safRSow1tye:k";
>  char short_bitmap_options[]=
> -               "-ABCDEFGIQhVXYWZ:vqb:c:i:l:p:m:n:x:u:c:d:z:U:N:sarfRSow1tye:k:";
> +               "-ABCDEFGIQhVXYWZ:vqb:c:i:l:p:m:r:n:x:u:c:d:z:U:N:safRSow1tye:k";
>  char short_bitmap_auto_options[]=
> -               "-ABCDEFGIQhVXYWZ:vqb:c:i:l:p:m:n:x:u:c:d:z:U:N:sa:rfRSow1tye:k:";
> +               "-ABCDEFGIQhVXYWZ:vqb:c:i:l:p:m:r:n:x:u:c:d:z:U:N:sa:RSow1tye:k";
> 
>  struct option long_options[] = {
>      {"manage",    0, 0, ManageOpt},
> --
> 2.23.0
>