Linux RAID subsystem development
 help / color / mirror / Atom feed
From: Jes Sorensen <jes.sorensen@gmail.com>
To: NeilBrown <neil@brown.name>
Cc: Linux Raid <linux-raid@vger.kernel.org>, jonathan.underwood@gmail.com
Subject: Re: [neilbrown/mdadm] Add udev-md-raid-safe-timeouts.rules (#32)
Date: Mon, 18 Dec 2017 10:32:31 -0500	[thread overview]
Message-ID: <a4f35e05-509c-553e-d047-3215a785fe9c@gmail.com> (raw)
In-Reply-To: <87h8ubsw9g.fsf@notabene.neil.brown.name>

On 11/03/2017 02:37 AM, NeilBrown wrote:
> 
> This pull request appeared on my github mdadm ... thing.
> 
> I haven't looked in detail.  If someone would like to review it
> or something, that would be nice.

Finally got around to looking at this. I am not hugely familiar with
smartctl, but it looks reasonable to me, especially since they won't be
auto-installed.

Jonathan, please make sure to always CC linux-raid on all mdadm related
patches. Note I prefer patches to git pull requests.

Thanks,
Jes


> Thanks,
> NeilBrown
> 
> On Fri, Nov 03 2017, jonathanunderwood wrote:
> 
>> These udev rules attempt to set a safe kernel controller
>> timeout for disks containing RAID level 1 or higher
>> partitions for commodity disks which do not have SCTERC
>> capability, or do have it but it is disabled.
>>
>> No attempt is made to change the STCERC settings on devices
>> which support it.
>>
>> This attempts to mitigate the problem described here:
>>
>>     https://raid.wiki.kernel.org/index.php/Timeout_Mismatch
>>     http://strugglers.net/~andy/blog/2015/11/09/linux-software-raid-and-drive-timeouts/
>>
>> where the kernel controller may timeout on a read from a
>> disk after the default timeout of 30 seconds and consequently
>> cause mdraid to regard the disk as dead and eject it from the
>> RAID array.
>>
>> The mitigation is to set the timeout to 180 seconds for disks
>> which contain a RAID level 1 or higher partition.
>> You can view, comment on, or merge this pull request online at:
>>
>>   https://github.com/neilbrown/mdadm/pull/32
>>
>> -- Commit Summary --
>>
>>   * Add udev-md-raid-safe-timeouts.rules
>>
>> -- File Changes --
>>
>>     A udev-md-raid-safe-timeouts.rules (61)
>>
>> -- Patch Links --
>>
>> https://github.com/neilbrown/mdadm/pull/32.patch
>> https://github.com/neilbrown/mdadm/pull/32.diff
>>
>> -- 
>> You are receiving this because you are subscribed to this thread.
>> Reply to this email directly or view it on GitHub:
>> https://github.com/neilbrown/mdadm/pull/32


  reply	other threads:[~2017-12-18 15:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <neilbrown/mdadm/pull/32@github.com>
2017-11-03  6:37 ` [neilbrown/mdadm] Add udev-md-raid-safe-timeouts.rules (#32) NeilBrown
2017-12-18 15:32   ` Jes Sorensen [this message]
2017-12-18 18:03     ` Jonathan Underwood
2018-01-21 21:11       ` Jes Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4f35e05-509c-553e-d047-3215a785fe9c@gmail.com \
    --to=jes.sorensen@gmail.com \
    --cc=jonathan.underwood@gmail.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neil@brown.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox