linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yu Kuai <yukuai1@huaweicloud.com>
To: Wang Jinchao <wangjinchao600@gmail.com>,
	Yu Kuai <yukuai1@huaweicloud.com>, Song Liu <song@kernel.org>
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
	"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH v2] md/raid1: Fix stack memory use after return in raid1_reshape
Date: Fri, 13 Jun 2025 17:15:49 +0800	[thread overview]
Message-ID: <a4f9b5a2-bf83-482e-e1fe-589f9ff004a1@huaweicloud.com> (raw)
In-Reply-To: <9275145b-3066-41e5-a971-eba219ef0d3c@gmail.com>

Hi,

在 2025/06/12 20:21, Wang Jinchao 写道:
> BTW, I feel raid1_reshape can be better coding with following:

And another hint:

The poolinfo can be removed directly, the only other place to use it
is r1buf_pool, and can covert to pass in conf or &conf->raid_disks.

Thanks,
Kuai


  reply	other threads:[~2025-06-13  9:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-11  8:55 [PATCH v2] md/raid1: Fix stack memory use after return in raid1_reshape Wang Jinchao
2025-06-12  7:31 ` Yu Kuai
2025-06-12  7:45   ` Wang Jinchao
2025-06-12  9:17     ` Yu Kuai
2025-06-12  9:55       ` Wang Jinchao
2025-06-12 11:23         ` Yu Kuai
2025-06-12 11:46           ` Wang Jinchao
2025-06-12 11:58             ` Yu Kuai
2025-06-12 12:21               ` Wang Jinchao
2025-06-13  9:15                 ` Yu Kuai [this message]
2025-06-13 11:53                   ` Wang Jinchao
2025-06-16 10:11                     ` Wang Jinchao
2025-06-16 11:32                       ` Yu Kuai
2025-06-18 11:47                         ` Wang Jinchao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4f9b5a2-bf83-482e-e1fe-589f9ff004a1@huaweicloud.com \
    --to=yukuai1@huaweicloud.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=song@kernel.org \
    --cc=wangjinchao600@gmail.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).