Re: [PATCH 2/3 v1] mdadm/test: Refactor the codes of 'test' script

[Jes Sorensen <jes.sorensen@gmail.com>]

On 06/08/2017 05:20 AM, Zhilong Liu wrote:
> Adding functions:
> die()
>    uniform the abnormal situations that have to abort.
> check_env()
>    do various basic checking before running test suite.
> save_log()
>    collect array infos, include of dmesg, superblock,
>    bitmap and /proc/mdstat.
> main()
>    the core function of this script.
> 
> Improve functions:
> cleanup()
>    clear dmesg and remove the /vat/tmp/mdtest* files.
> mdadm()
>    clear superblock once creating or building arrays
>    every time, because it's always creating arrays
>    many times in a test case.
> check()
>    just tidy up with die(), didn't change code meanings.
> testdev()
>    add checking $1 must be a block device, add 'return 0'
>    in final because this function exists in last line of
>    test case, such as tests/05r6tor0.
> do_test()
>    add checking abnormal dmesg and changing log management.
> do_help()
>    just recommend a better way to print Usage.
> parse_args()
>    just tidy up.
> 
> Signed-off-by: Zhilong Liu <zlliu@suse.com>
> ---
>   test | 346 +++++++++++++++++++++++++++++++++++++------------------------------
>   1 file changed, 191 insertions(+), 155 deletions(-)

Zhilong,

When sending out a v2 please add a small comment below the --- 
explaining what you changed.

Cheers,
Jes


PS: I note you start with v1 for updates, but v1 is really the first 
version - not a big deal.