From: "yu kuai" <yukuai@fygo.io>
To: "Sajal Gupta" <sajal2005gupta@gmail.com>,
<linux-raid@vger.kernel.org>, <song@kernel.org>,
"yu kuai" <yukuai@fygo.io>
Cc: <yukuai3@huawei.com>, <tomasz.majchrzak@intel.com>,
<linux-kernel@vger.kernel.org>, <error27@gmail.com>,
<skhan@linuxfoundation.org>, <me@brighamcampbell.com>,
<linux-kernel-mentees@lists.linux.dev>
Subject: Re: [PATCH v2] md/raid5-ppl: fix use-after-free in ppl_do_flush()
Date: Thu, 30 Jul 2026 16:09:34 +0800 [thread overview]
Message-ID: <acacbf2b-8f1f-4568-9246-12d9d8afd0f0@fygo.io> (raw)
In-Reply-To: <20260622142146.56637-1-sajal2005gupta@gmail.com>
在 2026/6/22 22:06, Sajal Gupta 写道:
> The loop in ppl_do_flush() continues iterating after calling
> ppl_io_unit_finished(), touching io->pending_flushes and leading to a
> use-after-free.
>
> Add a break statement to stop the loop once io is freed.
>
> Fixes: 1532d9e87e8b ("raid5-ppl: PPL support for disks with write-back cache enabled")
> Reported-by: Dan Carpenter<error27@gmail.com>
> Closes:https://lore.kernel.org/all/ajJF2wKYWRk4GGCK@stanley.mountain/
> Signed-off-by: Sajal Gupta<sajal2005gupta@gmail.com>
> ---
> Compile tested only.
>
> Changes in v2:
> - drop the refcount_t conversion
>
> v1:https://lore.kernel.org/all/20260622080656.22786-1-sajal2005gupta@gmail.com/
>
> drivers/md/raid5-ppl.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied to md-7.3
--
Thanks,
Kuai
prev parent reply other threads:[~2026-07-30 8:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 14:06 [PATCH v2] md/raid5-ppl: fix use-after-free in ppl_do_flush() Sajal Gupta
2026-06-24 4:42 ` Brigham Campbell
2026-06-24 8:07 ` Dan Carpenter
2026-07-05 9:02 ` yu kuai
2026-07-30 8:09 ` yu kuai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acacbf2b-8f1f-4568-9246-12d9d8afd0f0@fygo.io \
--to=yukuai@fygo.io \
--cc=error27@gmail.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=me@brighamcampbell.com \
--cc=sajal2005gupta@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=song@kernel.org \
--cc=tomasz.majchrzak@intel.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox