From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roland Dreier Subject: Re: Discard support Date: Fri, 14 Aug 2009 14:56:26 -0700 Message-ID: References: <200908122007.43522.ngupta@vflare.org> <20090813151312.GA13559@linux.intel.com> <20090813162621.GB1915@phenom2.trippelsdorf.de> <87f94c370908131115r680a7523w3cdbc78b9e82373c@mail.gmail.com> <87f94c370908131428u75dfe496x1b7d90b94833bf80@mail.gmail.com> <46b8a8850908131520s747e045cnd8db9493e072939d@mail.gmail.com> <87f94c370908131719l7d84c5d0x2157cfeeb2451bce@mail.gmail.com> <46b8a8850908131758s781b07f6v2729483c0e50ae7a@mail.gmail.com> <87f94c370908141433h111f819j550467bf31c60776@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <87f94c370908141433h111f819j550467bf31c60776@mail.gmail.com> (Greg Freemyer's message of "Fri, 14 Aug 2009 17:33:49 -0400") Sender: linux-ide-owner@vger.kernel.org To: Greg Freemyer Cc: Richard Sharpe , david@lang.hm, Markus Trippelsdorf , Matthew Wilcox , Hugh Dickins , Nitin Gupta , Ingo Molnar , Peter Zijlstra , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, Linux RAID List-Id: linux-raid.ids > It seems to me that unmap is not all that different, why do we need to > do it even close in time proximity to the deletes? With a bitmap, we > have total timing control of when the unmaps are forwarded down to the > device. I like that timing control much better than a cache and > coalesce approach. The trouble I see with a bitmap is the amount of memory it consumes. It seems that discards must be tracked on no bigger than 4KB sectors (and possibly even 512 byte sectors). But even with 4KB, then, say, a 32 TB volume (just 16 * 2TB disks, or even lower end with thin provisioning) requires 1 GB of bitmap memory. Which is a lot just to store, let alone walk over etc. - R.