From: Yu Kuai <yukuai1@huaweicloud.com>
To: Xiao Ni <xni@redhat.com>, linux-raid@vger.kernel.org
Cc: ncroxon@redhat.com, song@kernel.org, yukuai1@huaweicloud.com,
"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH V6 0/3] md: call del_gendisk in sync way
Date: Sat, 14 Jun 2025 16:18:01 +0800 [thread overview]
Message-ID: <b94ee45c-06ea-1d4d-8a88-7a88db1f0b6f@huaweicloud.com> (raw)
In-Reply-To: <20250611073108.25463-1-xni@redhat.com>
Hi,
在 2025/06/11 15:31, Xiao Ni 写道:
> Now del_gendisk is called in a queue work which has a small window
> that mdadm --stop command exits but the device node still exists.
> It causes trouble in regression tests. This patch set tries to resolve
> this problem.
>
> v1: replace MD_DELETED with MD_CLOSING
> v2: keep MD_CLOSING
> v3: call den_gendisk in mddev_unlock, and remove ->to_remove in stop path
> and adjust the order of patches
> v4: only remove the codes in stop path.
> v5: remove sysfs_remove in md_kobj_release and change EBUSY with ENODEV
> v6: don't initialize ret and add reviewed-by tag
>
> Xiao Ni (3):
> md: call del_gendisk in control path
> md: Don't clear MD_CLOSING until mddev is freed
> md: remove/add redundancy group only in level change
>
> drivers/md/md.c | 49 ++++++++++++++++++++++++++-----------------------
> drivers/md/md.h | 26 ++++++++++++++++++++++++--
> 2 files changed, 50 insertions(+), 25 deletions(-)
>
Just running mdadm tests with loop dev in my VM, and found this set can
cause many tests to fail, the first is 02r5grow:
++ /usr/sbin/mdadm -A /dev/md0 /dev/loop1 /dev/loop2 /dev/loop3
++ rv=1
++ case $* in
++ cat /var/tmp/stderr
mdadm: Unable to initialize sysfs
++ return 1
++ check state UUU
++ case $1 in
++ grep -sq 'blocks.*\[UUU\]$' /proc/mdstat
++ die 'state UUU not found!'
++ echo -e '\n\tERROR: state UUU not found! \n'
ERROR: state UUU not found!
++ save_log fail
I do not look into details yet.
Thanks
next prev parent reply other threads:[~2025-06-14 8:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 7:31 [PATCH V6 0/3] md: call del_gendisk in sync way Xiao Ni
2025-06-11 7:31 ` [PATCH 1/3] md: call del_gendisk in control path Xiao Ni
2025-06-11 7:31 ` [PATCH 2/3] md: Don't clear MD_CLOSING until mddev is freed Xiao Ni
2025-06-11 7:31 ` [PATCH 3/3] md: remove/add redundancy group only in level change Xiao Ni
2025-06-14 6:46 ` [PATCH V6 0/3] md: call del_gendisk in sync way Yu Kuai
2025-06-14 8:18 ` Yu Kuai [this message]
2025-06-15 3:21 ` Xiao Ni
2025-06-16 1:17 ` Yu Kuai
2025-06-16 1:43 ` Xiao Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b94ee45c-06ea-1d4d-8a88-7a88db1f0b6f@huaweicloud.com \
--to=yukuai1@huaweicloud.com \
--cc=linux-raid@vger.kernel.org \
--cc=ncroxon@redhat.com \
--cc=song@kernel.org \
--cc=xni@redhat.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).