From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: Re: md: Combine two kmalloc() calls into one in sb_equal() Date: Fri, 9 Dec 2016 22:58:22 +0100 Message-ID: References: <71044708-c5e4-3a14-b162-dfc600311a60@fastmail.fm> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Bernd Schubert Cc: linux-raid@vger.kernel.org, Shaohua Li , LKML , kernel-janitors@vger.kernel.org List-Id: linux-raid.ids > Irrelevant, the variable is not used before checking it. * Will it be more appropriate to attempt another memory allocation only if the previous one succeeded already? * Can it be a bit more efficient to duplicate only the required data in a single function call before? Regards, Markus