From: "Yu Kuai" <yukuai@fnnas.com>
To: <linan666@huaweicloud.com>, <song@kernel.org>, <xni@redhat.com>,
<linan122@huawei.com>
Cc: <linux-raid@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<yangerkun@huawei.com>, <yi.zhang@huawei.com>,
<bugreports61@gmail.com>, <yukuai@fnnas.com>
Subject: Re: [PATCH 1/2] md: Fix logical_block_size configuration being overwritten
Date: Thu, 25 Dec 2025 16:30:56 +0800 [thread overview]
Message-ID: <ba265bd3-1585-4a84-9ed0-32a3c6775c3b@fnnas.com> (raw)
In-Reply-To: <20251219092127.1815922-1-linan666@huaweicloud.com>
在 2025/12/19 17:21, linan666@huaweicloud.com 写道:
> From: Li Nan<linan122@huawei.com>
>
> In super_1_validate(), mddev->logical_block_size is directly overwritten
> with the value from metadata. This causes the previously configured lbs
> to be lost, making the configuration ineffective. Fix it.
>
> Fixes: 62ed1b582246 ("md: allow configuring logical block size")
> Signed-off-by: Li Nan<linan122@huawei.com>
> ---
> drivers/md/md.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)\
LGTM
Reviewed-by: Yu Kuai <yukuai@fnnas.com>
--
Thansk,
Kuai
prev parent reply other threads:[~2025-12-25 8:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 9:21 [PATCH 1/2] md: Fix logical_block_size configuration being overwritten linan666
2025-12-19 9:21 ` [PATCH 2/2] md: Fix forward incompatibility from configurable logical block size linan666
2025-12-25 8:39 ` Yu Kuai
2025-12-25 8:30 ` Yu Kuai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba265bd3-1585-4a84-9ed0-32a3c6775c3b@fnnas.com \
--to=yukuai@fnnas.com \
--cc=bugreports61@gmail.com \
--cc=linan122@huawei.com \
--cc=linan666@huaweicloud.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=xni@redhat.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox