Re: [PATCH] md: raid0: Make raid0_run() return a proper error code.

Andre Noll
2009-05-14T11:42:11Z

[-- Attachment #1: Type: text/plain, Size: 662 bytes --]

On 21:21, NeilBrown wrote:
> > conf->strip_zone = NULL;
> > conf->devlist = NULL;
> > - if (create_strip_zones (mddev))
> > + ret = create_strip_zones(mddev);
> > + if (ret < 0)
> > goto out_free_conf;
>
> Can we go one set further here and move the allocation of ->private
> into create_stripe_zones. It seems funny allocating it here and
> never actually using it directly.

Yes, I thought about that but wanted the patches to be as small as
possible. I'll follow up with another patch that moves the allocation
to create_stripe_zones().

Thanks
Andre
--
The only person who always got his work done by Friday was Robinson Crusoe

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]