Re: [PATCH] md: raid0: Replace hash table lookup by looping over all strip_zones.

Neil Brown
2009-05-14T12:22:33Z

On Thursday May 14, neilb@suse.de wrote:
>
> Then the loop could be
> for (i = 0; i < conf->nr_strip_zones; i++)
> if (sector < conf->strip_zone[i+1])
> return conf->strip_zone[i]
>
> Save our selves an 'add' that way :-)

That should have been

>
> Then the loop could be
> for (i = 0; i < conf->nr_strip_zones; i++)
> if (sector < conf->strip_zone[i+1]->zone_start)
> return conf->strip_zone[i]
>
> Save ourselves an 'add' that way :-)

and as we aren't using ->sectors in this loop any more, I think it
can be discarded completely, just making struct strip_zone 20% smaller
and improving cache performance.

What do you think?

NeilBrown