[PATCH] md: raid0: Make raid0_run() return a proper error code.

Andre Noll
2009-05-14T10:43:51Z

Currently raid0_run() always returns -ENOMEM on errors. This is
incorrect as running the array might fail for other reasons, for
example because not all component devices were available.

This patch changes create_strip_zones() so that it returns a proper
error code (either -ENOMEM or -EINVAL) rather than 1 on errors and
makes raid0_run(), its single caller, return that value instead
of -ENOMEM.

Signed-off-by: Andre Noll <maan@systemlinux.org>
---
drivers/md/raid0.c | 17 +++++++++--------
1 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
index 2401e94..0f4330f 100644
--- a/drivers/md/raid0.c
+++ b/drivers/md/raid0.c
@@ -106,12 +106,12 @@ static int create_strip_zones (mddev_t *mddev)
conf->strip_zone = kzalloc(sizeof(struct strip_zone)*
conf->nr_strip_zones, GFP_KERNEL);
if (!conf->strip_zone)
- return 1;
+ return -ENOMEM;
conf->devlist = kzalloc(sizeof(mdk_rdev_t*)*
conf->nr_strip_zones*mddev->raid_disks,
GFP_KERNEL);
if (!conf->devlist)
- return 1;
+ return -ENOMEM;

/* The first zone must contain all devices, so here we check that
* there is a proper alignment of slots to devices and find them all
@@ -211,8 +211,8 @@ static int create_strip_zones (mddev_t *mddev)

printk(KERN_INFO "raid0: done.\n");
return 0;
- abort:
- return 1;
+abort:
+ return -EINVAL;
}

/**
@@ -258,6 +258,7 @@ static sector_t raid0_size(mddev_t *mddev, sector_t sectors, int raid_disks)
static int raid0_run(mddev_t *mddev)
{
raid0_conf_t *conf;
+ int ret;

if (mddev->chunk_size == 0) {
printk(KERN_ERR "md/raid0: non-zero chunk size required.\n");
@@ -273,12 +274,13 @@ static int raid0_run(mddev_t *mddev)

conf = kmalloc(sizeof (raid0_conf_t), GFP_KERNEL);
if (!conf)
- goto out;
+ return -ENOMEM;
mddev->private = (void *)conf;

conf->strip_zone = NULL;
conf->devlist = NULL;
- if (create_strip_zones (mddev))
+ ret = create_strip_zones(mddev);
+ if (ret < 0)
goto out_free_conf;

/* calculate array device size */
@@ -310,8 +312,7 @@ out_free_conf:
kfree(conf->devlist);
kfree(conf);
mddev->private = NULL;
-out:
- return -ENOMEM;
+ return ret;
}

static int raid0_stop (mddev_t *mddev)
--
1.5.4.3