Re: [PATCH] md: raid0: Replace hash table lookup by looping over all strip_zones.

Raz
2009-05-15T21:19:01Z

I have not patched yet my code with this new serie, but where is patch
1/6 ? Does it exist or simply wrong numbering ?

On Fri, May 15, 2009 at 8:30 PM, Andre Noll <maan@systemlinux.org> wrote:
> On 18:51, raz ben yehuda wrote:
>
>> > and as we aren't using ->sectors in this loop any more, I think it
>> > can be discarded completely, just making struct strip_zone 20% smaller
>> > and improving cache performance.
>> >
>> > What do you think?
>> hamm.. please do not do it now. I think i need it for the reshape
>> because I have to traverse each zone up to its end.
>
> Well, you can always get the zone size of zone #i by
>
>        z[i].zone_end - z[i - 1].zone_end
>
> (with z[-1].zone_end := 0). Since reshape is a slow operation anyway,
> the additional subtraction won't hurt, and we'd have the smaller
> cache footprint during normal operation. So I'd be inclined to kill
> ->sectors as well.
>
> Andre
> --
> The only person who always got his work done by Friday was Robinson Crusoe
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.1 (GNU/Linux)
>
> iD8DBQFKDabAWto1QDEAkw8RAoEmAKCqYyRinCYIuXWi4fhJSLKfj//2XgCfYTfp
> z0lX/gg5fAfGb8IM0XKOAl4=
> =ShCN
> -----END PGP SIGNATURE-----
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html