From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jes Sorensen <jes.sorensen@gmail.com>
Subject: Re: [PATCH] mdadm: Unitialized variable rdev
Date: Mon, 15 May 2017 17:22:24 -0400
Message-ID: <bf542fb4-42d3-10b8-c770-ba98e45aff87@gmail.com>
References: <CA+wAi7cy6bMvv+uXWry=05E9biq0chUO2Wt9d91P6hQGZTVuMg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-raid-owner@vger.kernel.org>
In-Reply-To: <CA+wAi7cy6bMvv+uXWry=05E9biq0chUO2Wt9d91P6hQGZTVuMg@mail.gmail.com>
Content-Language: en-US
Sender: linux-raid-owner@vger.kernel.org
To: James John <joejames70@gmail.com>
Cc: linux-raid@vger.kernel.org
List-Id: linux-raid.ids

On 05/11/2017 05:15 PM, James John wrote:
> mdadm: Uninitialized variable rdev
> 
> rdev is not initialized properly causing compiler complaint.
> 
> Signed-off-by: James Puthukattukaran <joejames70@gmail.com>
> 
> diff --git a/super-ddf.c b/super-ddf.c
> index 9c82f4f..ac14017 100644
> --- a/super-ddf.c
> +++ b/super-ddf.c
> @@ -3526,7 +3526,7 @@ static int validate_geometry_ddf_bvd(
> struct supertype *st,
>                  return 1;
>          }
>          /* This device must be a member of the set */
> -       if (!stat_is_blkdev(dev, NULL))
> +       if (!stat_is_blkdev(dev, &rdev))
>                  return 0;
>          for (dl = ddf->dlist ; dl ; dl = dl->next) {
>                  if (dl->major == (int)major(rdev) &&
> 

Hi James,

This looks correct, but unfortunately you are using a broken mail client 
which replaced the tabs with spaces, and also included HTML junk.

Would you mind sending me a version that works, and I'll be happy to 
apply it.

Thanks,
Jes