From: "Guilherme G. Piccoli" <gpiccoli@canonical.com>
To: Song Liu <songliubraving@fb.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Song Liu <liu.song.a23@gmail.com>, NeilBrown <neilb@suse.com>,
linux-raid <linux-raid@vger.kernel.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
Jay Vosburgh <jay.vosburgh@canonical.com>
Subject: Re: [PATCH v2 1/2] md raid0/linear: Introduce new array state 'broken'
Date: Wed, 21 Aug 2019 11:16:25 -0300 [thread overview]
Message-ID: <c35cd395-fc54-24c0-1175-d3ea0ab0413d@canonical.com> (raw)
In-Reply-To: <8E880472-67DA-4597-AFAD-0DAFFD223620@fb.com>
On 19/08/2019 18:57, Song Liu wrote:
> [...]
> How about we test this when we do clear_bit(Faulty..)? And maybe also in
> add_new_disk()?
>
> Thanks,
> Song
>
Song, thanks for the suggestions. I've been working in the refactor, so
far it's working fine. But I cannot re-add a member to raid0/linear
without performing a full stop (with "mdadm --stop"), and in this case
md_clean() will clear the flag. Restarting array this way works fine.
If I try writing 'inactive' to array_state, I cannot reinsert the member
to the array. That said, I don't think we need to worry in clearing
MD_BROKEN for RAID0/LINEAR, and it makes things far easier.
Are you ok with that? I'll submit V3 after our discussion.
Thanks,
Guilherme
next prev parent reply other threads:[~2019-08-21 14:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 13:40 [PATCH v2 1/2] md raid0/linear: Introduce new array state 'broken' Guilherme G. Piccoli
2019-08-16 13:41 ` [PATCH v2 2/2] mdadm: Introduce new array state 'broken' for raid0/linear Guilherme G. Piccoli
2019-08-19 18:10 ` [PATCH v2 1/2] md raid0/linear: Introduce new array state 'broken' Song Liu
2019-08-19 18:30 ` Guilherme G. Piccoli
2019-08-19 18:57 ` Song Liu
2019-08-19 19:11 ` Guilherme G. Piccoli
2019-08-19 21:57 ` Song Liu
2019-08-21 14:16 ` Guilherme G. Piccoli [this message]
2019-08-21 16:14 ` Song Liu
2019-08-21 18:06 ` Song Liu
2019-08-21 19:10 ` Guilherme G. Piccoli
2019-08-21 19:22 ` Song Liu
2019-08-22 16:16 ` Guilherme G. Piccoli
2019-08-22 8:49 ` Guoqing Jiang
2019-08-22 15:35 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c35cd395-fc54-24c0-1175-d3ea0ab0413d@canonical.com \
--to=gpiccoli@canonical.com \
--cc=dm-devel@redhat.com \
--cc=jay.vosburgh@canonical.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=liu.song.a23@gmail.com \
--cc=neilb@suse.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox