Linux RAID subsystem development
 help / color / mirror / Atom feed
From: Yu Kuai <yukuai@kernel.org>
To: Luca Boccassi <luca.boccassi@gmail.com>,
	Yu Kuai <yukuai1@huaweicloud.com>
Cc: Xiao Ni <xni@redhat.com>,
	linux-raid@vger.kernel.org, mpatocka@redhat.com,
	"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH v4 1/1] md: add legacy_async_del_gendisk mode
Date: Mon, 18 Aug 2025 23:57:26 +0800	[thread overview]
Message-ID: <c488819f-c8b1-42fe-8557-1336fb713db1@kernel.org> (raw)
In-Reply-To: <CAMw=ZnR0HyaeG279BZybnJ9zYD5LbnjKS=U4Gc0w5bBs=i38BA@mail.gmail.com>

Hi,

在 2025/8/18 17:33, Luca Boccassi 写道:
> On Thu, 14 Aug 2025 at 01:54, Yu Kuai <yukuai1@huaweicloud.com> wrote:
>>
>> 在 2025/08/13 11:29, Xiao Ni 写道:
>>> commit 9e59d609763f ("md: call del_gendisk in control path") changes the
>>> async way to sync way of calling del_gendisk. But it breaks mdadm
>>> --assemble command. The assemble command runs like this:
>>> 1. create the array
>>> 2. stop the array
>>> 3. access the sysfs files after stopping
>>>
>>> The sync way calls del_gendisk in step 2, so all sysfs files are removed.
>>> Now to avoid breaking mdadm assemble command, this patch adds the parameter
>>> legacy_async_del_gendisk that can be used to choose which way. The default
>>> is async way. In future, we plan to change default to sync way in kernel
>>> 7.0. Then users need to upgrade to mdadm 4.5+ which removes step 2.
>>>
>>> Fixes: 9e59d609763f ("md: call del_gendisk in control path")
>>> Reported-by: Mikulas Patocka <mpatocka@redhat.com>
>>> Closes: https://lore.kernel.org/linux-raid/CAMw=ZnQ=ET2St-+hnhsuq34rRPnebqcXqP1QqaHW5Bh4aaaZ4g@mail.gmail.com/T/#t
>>> Suggested-and-reviewed-by: Yu Kuai <yukuai3@huawei.com>
>>> Signed-off-by: Xiao Ni <xni@redhat.com>
>>> ---
>>> v2: minor changes on format and log content
>>> v3: changes in commit message and log content
>>> v4: choose to change to sync way as default first in commit message
>>>    drivers/md/md.c | 56 ++++++++++++++++++++++++++++++++++++-------------
>>>    1 file changed, 42 insertions(+), 14 deletions(-)
>>>
>> Aplied to md-6.17
>> Thanks
> Hi,
>
> I noticed this bugfix is not in 6.17~rc2 released yesterday, will it
> be in rc3? Thanks

Yes. You should see this in linux-next soon, and later in rc3.

Thanks,
Kuai


  reply	other threads:[~2025-08-18 15:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-13  3:29 [PATCH v4 1/1] md: add legacy_async_del_gendisk mode Xiao Ni
2025-08-13  5:26 ` Paul Menzel
2025-08-13  6:34   ` Xiao Ni
2025-08-14  0:54 ` Yu Kuai
2025-08-18  9:33   ` Luca Boccassi
2025-08-18 15:57     ` Yu Kuai [this message]
2025-08-18 15:58       ` Luca Boccassi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c488819f-c8b1-42fe-8557-1336fb713db1@kernel.org \
    --to=yukuai@kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=luca.boccassi@gmail.com \
    --cc=mpatocka@redhat.com \
    --cc=xni@redhat.com \
    --cc=yukuai1@huaweicloud.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox