linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zdenek Kabelac <zdenek.kabelac@gmail.com>
To: Xiao Ni <xni@redhat.com>, Yu Kuai <yukuai1@huaweicloud.com>
Cc: mpatocka@redhat.com, song@kernel.org, linux-raid@vger.kernel.org,
	linux-kernel@vger.kernel.org, yi.zhang@huawei.com,
	yangerkun@huawei.com, johnny.chenyi@huawei.com,
	"yukuai (C)" <yukuai3@huawei.com>,
	Heinz Mauelshagen <heinzm@redhat.com>
Subject: Re: [PATCH v2] md/raid1,raid10: don't handle IO error for REQ_RAHEAD and REQ_NOWAIT
Date: Wed, 28 May 2025 11:27:04 +0200	[thread overview]
Message-ID: <c60f5fc9-6053-49d7-852f-fc581bd10169@gmail.com> (raw)
In-Reply-To: <CALTww2-_QoC7OCVSXHy=XfYE3K9m_CQ05HKX7QqJ504qnN=0cA@mail.gmail.com>

Dne 28. 05. 25 v 3:28 Xiao Ni napsal(a):
> CC Heinz who is a dm-raid expert. But he is on holiday this week.
> 
> On Tue, May 27, 2025 at 4:24 PM Yu Kuai <yukuai1@huaweicloud.com> wrote:
>>
>> Hi, Zdenek Kabelac
>>
>> 在 2025/05/27 16:14, Yu Kuai 写道:
>>> From: Yu Kuai <yukuai3@huawei.com>
>>>
>>> IO with REQ_RAHEAD or REQ_NOWAIT can fail early, even if the storage medium
>>> is fine, hence record badblocks or remove the disk from array does not
>>> make sense.
>>>
>>> This problem if found by lvm2 test lvcreate-large-raid, where dm-zero
>>> will fail read ahead IO directly.
>>>
>>> Reported-and-tested-by: Mikulas Patocka <mpatocka@redhat.com>
>>> Closes: https://lore.kernel.org/all/34fa755d-62c8-4588-8ee1-33cb1249bdf2@redhat.com/
>>> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
>>> ---
>>> Changes in v2:
>>>    - handle REQ_NOWAIT as well.
>>>
>>>    drivers/md/raid1-10.c | 10 ++++++++++
>>>    drivers/md/raid1.c    | 19 ++++++++++---------
>>>    drivers/md/raid10.c   | 11 ++++++-----
>>>    3 files changed, 26 insertions(+), 14 deletions(-)
>>>
>>
>> Just to let you know that while testing lvcreate-large-raid, the test
>> can fail sometime:
>>
>> [ 0:12.021] ## DEBUG0: 08:11:43.596775 lvcreate[8576]
>> device_mapper/ioctl/libdm-iface.c:2118  device-mapper: create ioctl on
>> LVMTEST8371vg1-LV1_rmeta_0
>> LVM-iqJjW9HItbME2d4DC2S7D58zd2omecjf0yQN83foinyxHaPoZqGEnX4rRUN7i0kH
>> failed: Device or resource busy

Hi

This issue is caused by occasional race with udev - which holds open our 
internal device open while we are deactivating raid LV.

We are currently trying to resolve this issue.

Regards

Zdenek


  reply	other threads:[~2025-05-28  9:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-27  8:14 [PATCH v2] md/raid1,raid10: don't handle IO error for REQ_RAHEAD and REQ_NOWAIT Yu Kuai
2025-05-27  8:24 ` Yu Kuai
2025-05-28  1:28   ` Xiao Ni
2025-05-28  9:27     ` Zdenek Kabelac [this message]
2025-05-30  6:43 ` Yu Kuai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c60f5fc9-6053-49d7-852f-fc581bd10169@gmail.com \
    --to=zdenek.kabelac@gmail.com \
    --cc=heinzm@redhat.com \
    --cc=johnny.chenyi@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=song@kernel.org \
    --cc=xni@redhat.com \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai1@huaweicloud.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).