linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jon Nelson" <jnelson-linux-raid@jamponi.net>
To: Neil Brown <neilb@suse.de>
Cc: LinuxRaid <linux-raid@vger.kernel.org>
Subject: Re: weird issues with raid1
Date: Thu, 18 Dec 2008 20:15:51 -0600	[thread overview]
Message-ID: <cccedfc60812181815oa63b526tb51c3bee558fbdf@mail.gmail.com> (raw)
In-Reply-To: <18761.60380.938542.26851@notabene.brown>

>> jnelson@turnip:~/kernels> (cd linux-2.6 && git diff
>> a0da84f35b25875870270d16b6eccda4884d61a7
>> a0da84f35b25875870270d16b6eccda4884d61a7^ ) > d.diff
>
> This is requesting the diff between a given version, and the previous
> version.  So it will be a reversed diff.

*sigh*

> i.e. these two lines are *added* by the patch.
> I usually use e.g.
>   git log -p a0da84f35b25875870270d16b6eccda4884d61a7
> to look at diffs.  Less room for confusion. (or gitk).

I will remember that one!

> and as those two lines are not present here, the patch as not been
> applied.

I'll apply and get back to you. My raid rebuilt 3 times today, quite
possibly because of this.

Obviously, I'm abusing the code in ways it was not intended to be
used. Sometimes that's good for finding corner-case-y kinds of issues,
though.

Thanks again for your patience.

-- 
Jon

  reply	other threads:[~2008-12-19  2:15 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-06  2:10 weird issues with raid1 Jon Nelson
2008-12-06  2:46 ` Jon Nelson
2008-12-06 12:16   ` Justin Piszcz
2008-12-15  2:17     ` Jon Nelson
2008-12-15  6:00 ` Neil Brown
2008-12-15 13:42   ` Jon Nelson
2008-12-15 21:33     ` Neil Brown
2008-12-15 21:47       ` Jon Nelson
2008-12-16  1:21         ` Neil Brown
2008-12-16  2:32           ` Jon Nelson
2008-12-18  4:42           ` Neil Brown
2008-12-18  4:50             ` Jon Nelson
2008-12-18  4:55               ` Jon Nelson
2008-12-18  5:17                 ` Neil Brown
2008-12-18  5:47                   ` Jon Nelson
2008-12-18  6:21                     ` Neil Brown
2008-12-19  2:15                       ` Jon Nelson [this message]
2008-12-19 16:51                         ` Jon Nelson
2008-12-19 20:40                           ` Jon Nelson
2008-12-19 21:18                             ` Jon Nelson
2008-12-22 14:40                               ` Jon Nelson
2008-12-22 21:07                                 ` NeilBrown
2008-12-18  5:43   ` Neil Brown
2008-12-18  5:54     ` Jon Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cccedfc60812181815oa63b526tb51c3bee558fbdf@mail.gmail.com \
    --to=jnelson-linux-raid@jamponi.net \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).