Re: [PATCH] IMSM: Correct --examine output for 4k disks

[Mariusz Dabrowski <mariusz.dabrowski@intel.com>]

On 05/10/2017 05:18 PM, Jes Sorensen wrote:
> On 05/10/2017 04:43 AM, Mariusz Dabrowski wrote:
>> On 05/09/2017 06:04 PM, Jes Sorensen wrote:
>>  > On 05/09/2017 08:03 AM, Mariusz Dabrowski wrote:
>>  >> From: Maksymilian Kunt <maksymilian.kunt@intel.com>
>>  >>
>>  >> "Array Size" and "Per Dev Size" are incorrect for disks with sector size
>>  >> different than 512B.
>>  >>
>>  >> Calculate "Array Size" and "Per Dev Size" based on sector size. Additionally
>>  >> print "Sector Size".
>>  >>
>>  >> Signed-off-by: Maksymilian Kunt <maksymilian.kunt@intel.com>
>>  >> Signed-off-by: Mariusz Dabrowski <mariusz.dabrowski@intel.com>
>>  >> ---
>>  >>   super-intel.c | 7 +++++--
>>  >>   1 file changed, 5 insertions(+), 2 deletions(-)
>>  >
>>  > I am a little wary of this change as it changes the order of the output. Does
>>  > anyone have tools parsing this information which could break from this?
>>  >
>>  > Jes
>>  >
>>
>> Hi Jes,
>>
>> some time ago we have added "RWH Policy" field to --examine output and we
>> haven't heard any complaints about that change.
>> Also it is better to parse output from --export option which is unchanged in
>> this patch.
>
> Hi Mariusz,
>
> That is correct, however the policy stuff was added to the end of the output, it
> didn't change the existing part. I am a little mixed on this one, but I do agree
> --export should be the recommended use case for scripts.
>
> Cheers,
> Jes

Are you willing to accept this patch if no one disagrees or should I remove this 
additional field and resend the patch?