From: Jens Axboe <axboe@kernel.dk>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Thorsten Leemhuis <regressions@leemhuis.info>,
Christoph Hellwig <hch@lst.de>, Dusty Mabe <dusty@dustymabe.com>,
Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-raid@vger.kernel.org,
"regressions@lists.linux.dev" <regressions@lists.linux.dev>
Subject: Re: regression caused by block: freeze the queue earlier in del_gendisk
Date: Wed, 21 Sep 2022 08:56:53 -0600 [thread overview]
Message-ID: <cecf4c71-14be-4ff8-df83-cfd1da102bcf@kernel.dk> (raw)
In-Reply-To: <Yysj6AXQ44/el4pS@kroah.com>
On Wed, Sep 21, 2022 at 8:47 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Wed, Sep 21, 2022 at 08:34:26AM -0600, Jens Axboe wrote:
> > On 9/21/22 3:25 AM, Thorsten Leemhuis wrote:
> > > On 20.09.22 16:14, Jens Axboe wrote:
> > >> On 9/20/22 8:12 AM, Christoph Hellwig wrote:
> > >>> On Tue, Sep 20, 2022 at 08:05:06AM -0600, Jens Axboe wrote:
> > >>>> Christoph and I discussed this one last week, and he has a plan to try
> > >>>> a flag approach. Christoph, did you get a chance to bang that out? Would
> > >>>> be nice to get this one wrapped up.
> > >>>
> > >>> I gave up on that as it will be far too much change so late in
> > >>> the cycle and sent you the revert yesterday.
> > >>
> > >> Gotcha, haven't made it all the way through the emails of the morning yet.
> > >> I'll queue it up.
> > >
> > > Thx to both of you for taking care of this.
> > >
> > > Nitpicking: that patch is missing a "CC: stable@..." tag to ensure
> > > automatic and quick backporting to 5.19.y. Or is the block layer among
> > > the subsystems that prefer to handle such things manually?
> > >
> > > Ohh, and a fixes tag might have been good as well; a "Link:" tag
> > > pointing to the report, too. If either would have been there, regzbot
> > > would have noticed Christoph's patch posting and I wouldn't have
> > > bothered you yesterday. :-) But whatever, not that important.
> >
> > We'll just have to ensure we ping stable on it when it goes in.
>
> If you have a git id that is not going to change, I can watch out for it
> to land in Linus's tree...
This is the one:
commit 4c66a326b5ab784cddd72de07ac5b6210e9e1b06 (origin/block-6.0, block-6.0)
Author: Christoph Hellwig <hch@lst.de>
Date: Mon Sep 19 16:40:49 2022 +0200
Revert "block: freeze the queue earlier in del_gendisk"
Thanks Greg!
--
Jens Axboe
next prev parent reply other threads:[~2022-09-21 14:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <017845ae-fbae-70f6-5f9e-29aff2742b8c@dustymabe.com>
[not found] ` <9968ab01-f9c4-ee47-9dd0-9e46560e459e@leemhuis.info>
2022-08-31 12:36 ` regression caused by block: freeze the queue earlier in del_gendisk Thorsten Leemhuis
2022-09-01 7:06 ` Ming Lei
2022-09-03 13:47 ` Dusty Mabe
2022-09-07 7:33 ` Christoph Hellwig
2022-09-07 8:38 ` Ming Lei
2022-09-07 14:40 ` Chaitanya Kulkarni
2022-09-07 14:58 ` Ming Lei
2022-09-07 15:53 ` Chaitanya Kulkarni
2022-09-09 8:24 ` Ming Lei
2022-09-12 7:16 ` Christoph Hellwig
2022-09-13 1:55 ` Ming Lei
2022-09-13 2:36 ` Dusty Mabe
2022-09-20 9:11 ` Thorsten Leemhuis
2022-09-20 14:05 ` Jens Axboe
2022-09-20 14:12 ` Christoph Hellwig
2022-09-20 14:14 ` Jens Axboe
2022-09-21 9:25 ` Thorsten Leemhuis
2022-09-21 14:34 ` Jens Axboe
2022-09-21 14:47 ` Greg KH
2022-09-21 14:56 ` Jens Axboe [this message]
2022-09-26 7:09 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cecf4c71-14be-4ff8-df83-cfd1da102bcf@kernel.dk \
--to=axboe@kernel.dk \
--cc=dusty@dustymabe.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).