From: John Garry <john.g.garry@oracle.com>
To: Nilay Shroff <nilay@linux.ibm.com>,
agk@redhat.com, snitzer@kernel.org, mpatocka@redhat.com,
song@kernel.org, yukuai3@huawei.com, hch@lst.de, axboe@kernel.dk,
cem@kernel.org
Cc: dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-raid@vger.kernel.org, linux-block@vger.kernel.org,
ojaswin@linux.ibm.com, martin.petersen@oracle.com,
akpm@linux-foundation.org, linux-xfs@vger.kernel.org,
djwong@kernel.org
Subject: Re: [PATCH v4 6/6] block: use chunk_sectors when evaluating stacked atomic write limits
Date: Tue, 8 Jul 2025 13:36:54 +0100 [thread overview]
Message-ID: <d84e0629-28a4-4876-9395-4eb1d4bb280c@oracle.com> (raw)
In-Reply-To: <51e56dcf-6a64-42d1-b488-7043f880026e@linux.ibm.com>
On 08/07/2025 13:27, Nilay Shroff wrote:
>> + if ((unsigned long)chunk_sectors << SECTOR_SHIFT > UINT_MAX)
>> + chunk_bytes = chunk_sectors;
>> + else
>> + chunk_bytes = chunk_sectors << SECTOR_SHIFT;
>>
> Can we use check_shl_overflow() here for checking overflow?
ok, I can change.
> Otherwise,
> changes look good to me. I've also tested it using my NVMe disk which
> supports up to 256kb of atomic writes.
> > Reviewed-by: Nilay Shroff<nilay@linux.ibm.com>
> Tested-by: Nilay Shroff<nilay@linux.ibm.com>
thanks
next prev parent reply other threads:[~2025-07-08 12:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 13:11 [PATCH v4 0/6] block/md/dm: set chunk_sectors from stacked dev stripe size John Garry
2025-07-07 13:11 ` [PATCH v4 1/6] ilog2: add max_pow_of_two_factor() John Garry
2025-07-07 13:11 ` [PATCH v4 2/6] block: sanitize chunk_sectors for atomic write limits John Garry
2025-07-07 13:11 ` [PATCH v4 3/6] md/raid0: set chunk_sectors limit John Garry
2025-07-07 13:11 ` [PATCH v4 4/6] md/raid10: " John Garry
2025-07-07 13:11 ` [PATCH v4 5/6] dm-stripe: limit chunk_sectors to the stripe size John Garry
2025-07-07 13:11 ` [PATCH v4 6/6] block: use chunk_sectors when evaluating stacked atomic write limits John Garry
2025-07-08 12:27 ` Nilay Shroff
2025-07-08 12:36 ` John Garry [this message]
2025-07-08 16:59 ` Mikulas Patocka
2025-07-08 18:00 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d84e0629-28a4-4876-9395-4eb1d4bb280c@oracle.com \
--to=john.g.garry@oracle.com \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mpatocka@redhat.com \
--cc=nilay@linux.ibm.com \
--cc=ojaswin@linux.ibm.com \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox