linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jes Sorensen <jes.sorensen@gmail.com>
To: Zhilong Liu <zlliu@suse.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH 0/3] mdadm/test: Refactor the codes of 'test' script
Date: Fri, 9 Jun 2017 11:08:23 -0400	[thread overview]
Message-ID: <d92b0a65-198b-3637-83a1-a71b78cdfd43@gmail.com> (raw)
In-Reply-To: <1496827888-17118-1-git-send-email-zlliu@suse.com>

On 06/07/2017 05:31 AM, Zhilong Liu wrote:
> Hi, Jes;
>    This patchset mainly focus on improving the 'test' script, rip it
> apart and put it together in a more coherent form.
>    Over 3 months passed, the RFC patch of improving 'test' hadn't received
> any ideas, thus I post this sample version that I have tested many times.
>    It's just the beginning to improve the test part of mdadm, any questions
> is very welcome.
> 
>    Sorry for that, I haven't added the function suggested from Guoqing, cut
> the words from the email tree of
> "ANNOUNCE: mdadm 4.0 - A tool for managing md Soft RAID under Linux":
> 
> Guoqing asked:
> ...
> Is current test can run the test for different raid level, say,
> "./test --raidtype=raid1"
> could execute all the *r1* tests, does it make sense to do it if we don't
> support it now.
> ...
> 
>    Just list this suggestion here, waiting for ideas.
> 
> RFC patch mail-tree:
> [PATCH RFC] test: revise 'test' and make it easier to understand
> Acked-by: Neil Brown
> And suggest to split those changing into smaller patches from Guoqing.

The whole test infrastructure is something I would like to see rewamped 
and modernized, so you starting to work on this is excellent.

With regard to your question, then having an option to say 'run all 
raid1 tests' is probably good, we should have that for all raid levels, 
imsm, and ddf.

I also would like to see a more flexible way to configure the tests, 
like it should be possible to specify a bunch of physical devices for 
the tests, instead of relying on loop devices.

Cheers,
Jes



  parent reply	other threads:[~2017-06-09 15:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-07  9:31 [PATCH 0/3] mdadm/test: Refactor the codes of 'test' script Zhilong Liu
2017-06-07  9:31 ` [PATCH 1/3] mdadm/test: Convert code format to use Tab Zhilong Liu
2017-06-09 15:06   ` Jes Sorensen
2017-06-07  9:31 ` [PATCH 2/3] mdadm/test: Refactor the codes of 'test' script Zhilong Liu
2017-06-08  9:20   ` [PATCH 2/3 v1] " Zhilong Liu
2017-06-09 15:05     ` Jes Sorensen
2017-06-07  9:31 ` [PATCH 3/3] mdadm/test: Get rid of fast_sync() Zhilong Liu
2017-06-09 15:08 ` Jes Sorensen [this message]
2017-06-12  2:32   ` [PATCH 0/3] mdadm/test: Refactor the codes of 'test' script Zhilong Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d92b0a65-198b-3637-83a1-a71b78cdfd43@gmail.com \
    --to=jes.sorensen@gmail.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=zlliu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).