From mboxrd@z Thu Jan  1 00:00:00 1970
From: zhilong <zlliu@suse.com>
Subject: Re: [PATCH] Monitor: dev should be a block file in waitclean
Date: Fri, 24 Feb 2017 11:07:29 +0800
Message-ID: <ddee1eaf-db45-c52d-5cde-12728430d786@suse.com>
References: <1487058625-28852-1-git-send-email-zlliu@suse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-raid-owner@vger.kernel.org>
In-Reply-To: <1487058625-28852-1-git-send-email-zlliu@suse.com>
Sender: linux-raid-owner@vger.kernel.org
To: Jes.Sorensen@redhat.com
Cc: linux-raid@vger.kernel.org
List-Id: linux-raid.ids

Hi, Jes;
   I just wanted to ping and see if this could get a review:


On 02/14/2017 03:50 PM, Zhilong Liu wrote:
>      mdadm --wait-clean /dev/mdX, the dev should
>      be a block file, otherwise fd2devnm returns
>      NULL and triggers core dumped.
>
> Signed-off-by: Zhilong Liu <zlliu@suse.com>
>
> diff --git a/Monitor.c b/Monitor.c
> index 802a9d9..d16ac49 100644
> --- a/Monitor.c
> +++ b/Monitor.c
> @@ -1060,7 +1060,17 @@ int WaitClean(char *dev, int sock, int verbose)
>   	struct mdinfo *mdi;
>   	int rv = 1;
>   	char devnm[32];
> +	struct stat stb;
>   
> +	if (stat(dev, &stb) != 0) {
> +		pr_err("Cannot find %s: %s\n", dev,
> +			strerror(errno));
> +		return 2;
> +	}
> +	if ((S_IFMT & stb.st_mode) != S_IFBLK) {
> +		pr_err("%s is not a block device.\n", dev);
> +		return 2;
> +	}
>   	fd = open(dev, O_RDONLY);
>   	if (fd < 0) {
>   		if (verbose)