From: Jes Sorensen <jes@trained-monkey.org>
To: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
Cc: Kinga Tanska <kinga.tanska@intel.com>,
linux-raid@vger.kernel.org, colyli@suse.de
Subject: Re: [PATCH] Assemble: fix redundant memory free
Date: Thu, 26 Oct 2023 17:21:09 -0400 [thread overview]
Message-ID: <df2a31f1-080b-0150-42f1-c5e9c647d70b@trained-monkey.org> (raw)
In-Reply-To: <20230912114902.00003e1c@linux.intel.com>
On 9/12/23 05:49, Mariusz Tkaczyk wrote:
> On Tue, 12 Sep 2023 04:27:01 +0200
> Kinga Tanska <kinga.tanska@intel.com> wrote:
>
>> Commit e9fb93af0f76 ("Fix memory leak in file Assemble")
>> fixes few memory leaks in Assemble, but it introduces
>> problem with assembling RAID volume. It was caused by
>> clearing metadata too fast, not only on fail in
>> select_devices() function.
>> This commit removes redundant memory free.
>>
>> Signed-off-by: Kinga Tanska <kinga.tanska@intel.com>
>> ---
>> Assemble.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/Assemble.c b/Assemble.c
>> index 61e8cd17..5be58e40 100644
>> --- a/Assemble.c
>> +++ b/Assemble.c
>> @@ -428,8 +428,6 @@ static int select_devices(struct mddev_dev *devlist,
>>
>> /* make sure we finished the loop */
>> tmpdev = NULL;
>> - free(st);
>> - st = NULL;
>> goto loop;
>> } else {
>> content = *contentp;
>
> Hi Jes,
> It is a regression. Please merge it ASAP, it broke a a lot of our tests.
Applied!
Sorry for missing this.
Thanks,
Jes
prev parent reply other threads:[~2023-10-26 21:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 2:27 [PATCH] Assemble: fix redundant memory free Kinga Tanska
2023-09-12 9:49 ` Mariusz Tkaczyk
2023-10-26 21:21 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df2a31f1-080b-0150-42f1-c5e9c647d70b@trained-monkey.org \
--to=jes@trained-monkey.org \
--cc=colyli@suse.de \
--cc=kinga.tanska@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=mariusz.tkaczyk@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).