From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F10403CCFD6; Fri, 27 Mar 2026 08:25:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774599945; cv=none; b=FW+/DIko+z8FjjI3CxzScirOWSop9xmrtlH1PltdUAYnR9WegCSbVP87vqfqpOjW4btan9P2/A+bqCnfyGL85g8abY1LPjr62svuUlK0040hx9zqQRht7cWp2uWmr69c7r51Hp0PPeaYFt3vbFX2x1yg0n+QH/LAYQZCHz7XD1I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774599945; c=relaxed/simple; bh=oGcTlThlcrf/a6X6Pba0yaQBbOhK2gU5HD6vMRqLYbw=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=IsqpKkyZvpr6+4JsNjEYRr2MtEzPXN58z4MImpmKH9HW98/oeXoQTySGqe37RQy98tsO5cJkFSoi+2I4UV9zcWdN7zHa1JJpVHwBIMp6ub4VYLNfweUTNM1SRotdtG516KSUB+jHabfbsI9vRc+uViODIEEBOOfiNRRWNzQF7qA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iBfAOMCd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iBfAOMCd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CCCFC19423; Fri, 27 Mar 2026 08:25:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774599944; bh=oGcTlThlcrf/a6X6Pba0yaQBbOhK2gU5HD6vMRqLYbw=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=iBfAOMCdNXVUtbWDhBFGcWilDfE39obo76ocBxQznbM3ycVkcYhKsIhWHf4vRxpPL bIkBK9J2OZ0i1KQbkC6Im5qIQj9zl5VvaINRhPxvjhpPwTtcNwmB89dciCiEcjaXPj hcxN2d4AsZE14afNOgOlwlYJUZWJEZjvIDMy0leuTEJ2dX90MDcoc2jd+/FaLpUhg9 8STIOBpp52KDxyMdqI3OdiX8fopCv8rwjKrncy6nVONdpwBnAwSZw+1zDNvQDozbvR EH7kR87WXyeqs8FRjqzdiiOl6zl/d4tv6D5jmnhDRy5G3fxGfGm3vaYDviebgudkkB jVzLQ0XrKaPWg== Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfauth.phl.internal (Postfix) with ESMTP id 68109F4006B; Fri, 27 Mar 2026 04:25:43 -0400 (EDT) Received: from phl-imap-02 ([10.202.2.81]) by phl-compute-01.internal (MEProxy); Fri, 27 Mar 2026 04:25:43 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdefvdelkedtucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddtnecuhfhrohhmpedftehrugcu uehivghshhgvuhhvvghlfdcuoegrrhgusgeskhgvrhhnvghlrdhorhhgqeenucggtffrrg htthgvrhhnpedvueehiedtvedtleekuddutefgffdtleetfeetveejveejieehfefhjeei jeefudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhguodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdduieejtdehtddtjeel qdeffedvudeigeduhedqrghruggspeepkhgvrhhnvghlrdhorhhgseifohhrkhhofhgrrh gurdgtohhmpdhnsggprhgtphhtthhopeejpdhmohguvgepshhmthhpohhuthdprhgtphht thhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtph htthhopehlihhnuhigqdhrrghiugesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphht thhopehlihhnuhigqdhsfeeltdesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtth hopehsphgrrhgtlhhinhhugiesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthho pehkvghrnhgvlhesgigvnhdtnhdrnhgrmhgvpdhrtghpthhtohepjhgrshhonhesiiigvd gtgedrtghomhdprhgtphhtthhopehhphgrseiihihtohhrrdgtohhm X-ME-Proxy: Feedback-ID: ice86485a:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 3B247700065; Fri, 27 Mar 2026 04:25:43 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-raid@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: ALG_cRBuf6HF Date: Fri, 27 Mar 2026 09:25:22 +0100 From: "Ard Biesheuvel" To: "Christoph Hellwig" , "Andrew Morton" Cc: "Richard Henderson" , "Matt Turner" , "Magnus Lindholm" , "Russell King" , "Catalin Marinas" , "Will Deacon" , "Huacai Chen" , "WANG Xuerui" , "Madhavan Srinivasan" , "Michael Ellerman" , "Nicholas Piggin" , "Christophe Leroy (CS GROUP)" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Alexandre Ghiti" , "Heiko Carstens" , "Vasily Gorbik" , "Alexander Gordeev" , "Christian Borntraeger" , "Sven Schnelle" , "David S. Miller" , "Andreas Larsson" , "Richard Weinberger" , "Anton Ivanov" , "Johannes Berg" , "Thomas Gleixner" , "Ingo Molnar" , "Borislav Petkov" , "Dave Hansen" , x86@kernel.org, "H . Peter Anvin" , "Herbert Xu" , "Dan Williams" , "Chris Mason" , "David Sterba" , "Arnd Bergmann" , "Song Liu" , "Yu Kuai" , "Li Nan" , "Theodore Ts'o" , "Jason A . Donenfeld" , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-arch@vger.kernel.org, linux-raid@vger.kernel.org Message-Id: In-Reply-To: <20260327061704.3707577-4-hch@lst.de> References: <20260327061704.3707577-1-hch@lst.de> <20260327061704.3707577-4-hch@lst.de> Subject: Re: [PATCH 03/28] arm64/xor: fix conflicting attributes for xor_block_template Content-Type: text/plain Content-Transfer-Encoding: 7bit On Fri, 27 Mar 2026, at 07:16, Christoph Hellwig wrote: > Commit 2c54b423cf85 ("arm64/xor: use EOR3 instructions when available") > changes the definition to __ro_after_init instead of const, but failed to > update the external declaration in xor.h. This was not found because > xor-neon.c doesn't include , and can't easily do that due to > current architecture of the XOR code. > Even if it did, it wouldn't matter - __ro_after_init has no effect on declarations, only on definitions - it only controls the placement of the object in the .data..ro_after_init section (and declarations don't generate any code) > Fixes: 2c54b423cf85 ("arm64/xor: use EOR3 instructions when available") > Signed-off-by: Christoph Hellwig > --- > arch/arm64/include/asm/xor.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >