From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Williams Subject: Re: [PATCH 06/13] async_tx: add support for asynchronous GF multiplication Date: Sat, 21 Mar 2009 15:46:12 -0700 Message-ID: References: <20090318191248.20375.40560.stgit@dwillia2-linux.ch.intel.com> <49C41C1E.4060401@zytor.com> <49C4201A.5060905@emcraft.com> <49C425F5.8060309@intel.com> <49C42F99.5010700@emcraft.com> <49C45159.8020503@zytor.com> <49C53CC0.5060303@zytor.com> <49C5699C.8050405@emcraft.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <49C5699C.8050405@emcraft.com> Sender: linux-raid-owner@vger.kernel.org To: Ilya Yanok Cc: "H. Peter Anvin" , "H. Peter Anvin" , "linux-raid@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "neilb@suse.de" , "Sosnowski, Maciej" , Yuri Tikhonov List-Id: linux-raid.ids On Sat, Mar 21, 2009 at 3:26 PM, Ilya Yanok wrote: >> The caller needs to be modified to only require scalar multiplication >> even in this corner case. >> > > Argh... There is no vector-vector multiplication at all! You just need > to swap the 'for' cycles back (as it was in the original patch by me and > Yuri) to get rid of two-dimensional lookup at each step. Yes, I swapped the loops as part of the removal of the ASYNC_TX_ZERO_{P,Q} flags and wanted to avoid an explicit memset. I'll rework this path... Regards, Dan