Re: [GIT PATCH 0/2] external-metadata recovery checkpointing for 2.6.33

[Dan Williams <dan.j.williams@intel.com>]

On Sun, Dec 13, 2009 at 9:07 PM, Neil Brown <neilb@suse.de> wrote:
> On Sat, 12 Dec 2009 21:17:01 -0700
> Dan Williams <dan.j.williams@intel.com> wrote:
>
>>       md: add 'recovery_start' sysfs attribute
>
> This one I don't like so much.
> recovery_start should be a per-device value, not a per-array value,
> and each device can theoretically have been recovered to a different place.
> We don't make much use of that fact, but maybe we could one day.
>
> So I have change the code to simply expose rdev->recovery_offset through
> sysfs, which should provide all the functionality you need.

Yes, and more flexible in the long run, ack.

> Patch below.
> It still says "From: Dan Williams" because I started with you patch
> and then changes almost all of it (but not quite all).  That seems a
> bit odd but doesn't bother me - tell me if it bothers you.

I've typically added an akpm inspired:
[foo@bar.com: made some mods]
...note when I have touched other people's patches, but it's not a big
deal to me.

> +static ssize_t recovery_start_store(mdk_rdev_t *rdev, const char *buf, size_t len)
> +{
> +       unsigned long long recovery_start;
> +
> +       if (cmd_match(buf, "none"))
> +               recovery_start = MaxSector;

Should probably do the same for resync_start to be consistent?

Thanks,
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html