Re: [PATCH]mdadm: fix coredump of mdadm --monitor -r

["Tkaczyk, Mariusz" <mariusz.tkaczyk@linux.intel.com>]

On 19.08.2021 10:21, Wu Guanghao wrote:
> ping
> 
> 在 2021/8/16 15:24, Wu Guanghao 写道:
>> Hi,
>>
>> The --monitor -r option requires a parameter, otherwise a null pointer will be manipulated
>> when converting to integer data, and a coredump will appear.
>>
>> # mdadm --monitor -r
>> Segmentation fault (core dumped)
>>
>> Signed-off-by: Wu Guanghao <wuguanghao3@huawei.com>
>> ---
>>   ReadMe.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/ReadMe.c b/ReadMe.c
>> index 06b8f7e..070a164 100644
>> --- a/ReadMe.c
>> +++ b/ReadMe.c
>> @@ -81,11 +81,11 @@ char Version[] = "mdadm - v" VERSION " - " VERS_DATE EXTRAVERSION "\n";
>>    *     found, it is started.
>>    */
>>
>> -char short_options[]="-ABCDEFGIQhVXYWZ:vqbc:i:l:p:m:n:x:u:c:d:z:U:N:sarfRSow1tye:k:";
>> +char short_options[]="-ABCDEFGIQhVXYWZ:vqbc:i:l:p:m:r:n:x:u:c:d:z:U:N:safRSow1tye:k";
>>   char short_bitmap_options[]=
>> -               "-ABCDEFGIQhVXYWZ:vqb:c:i:l:p:m:n:x:u:c:d:z:U:N:sarfRSow1tye:k:";
>> +               "-ABCDEFGIQhVXYWZ:vqb:c:i:l:p:m:r:n:x:u:c:d:z:U:N:safRSow1tye:k";
>>   char short_bitmap_auto_options[]=
>> -               "-ABCDEFGIQhVXYWZ:vqb:c:i:l:p:m:n:x:u:c:d:z:U:N:sa:rfRSow1tye:k:";
>> +               "-ABCDEFGIQhVXYWZ:vqb:c:i:l:p:m:r:n:x:u:c:d:z:U:N:sa:RSow1tye:k";
>>
>>   struct option long_options[] = {
>>       {"manage",    0, 0, ManageOpt},
>> --
>> 2.23.0
>> .
>>

Acked-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>

Thanks,
Mariusz