From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Markus Hochholdinger <Markus@hochholdinger.net>
Cc: song@kernel.org, linux-raid@vger.kernel.org, xni@redhat.com
Subject: Re: [PATCH] md: fix update super 1.0 on rdev size change
Date: Tue, 16 Nov 2021 10:52:15 +0100 [thread overview]
Message-ID: <f08f5e72-dcf4-7f89-21eb-e293b3db0dbf@molgen.mpg.de> (raw)
In-Reply-To: <2299535.YZZJjEnbGj@enterprise>
Dear Markus,
Am 16.11.21 um 10:44 schrieb Markus Hochholdinger:
> Am Dienstag, 16. November 2021, 10:24:17 CET schrieb Paul Menzel:
[…]
>> Am 12.11.21 um 15:28 schrieb markus@hochholdinger.net:
>>> From: Markus Hochholdinger <markus@hochholdinger.net>
>>> The superblock of version 1.0 doesn't get moved to the new position on a
>>> device size change. This leads to a rdev without a superblock on a known
>>> position, the raid can't be re-assembled.
>>> Fixes: commit d9c0fa509eaf ("md: fix max sectors calculation for super
>>> 1.0")
>> I think it’s common to not write *commit* in there, but just the short
>> hash. `scripts/checkpatch.pl` does not mention that, but it mentions:
>> ERROR: Missing Signed-off-by: line(s)
>> total: 1 errors, 0 warnings, 7 lines checked
>
> I'm sorry, this was my first patch request against the linux kernel.
Awesome. We all started with that.
> Within https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
> tree/Documentation/process/submitting-patches.rst I read to sign off a patch if
> it is from me, but the line was there before. So I thought I don't have to
> sign it.
No, even reverts have to be signed off.
> Should I do the patch request again with Signed-off information?
Yes, please do, and maybe amend the commit message, to mention, that the
line was removed by mistake, and is added back.
You can create a v2 easily with the `git send-email` switch below:
-v <n>, --reroll-count=<n>
You can also add the Reviewed-by lines you already got.
[…]
Kind regards,
Paul
prev parent reply other threads:[~2021-11-16 9:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 14:28 [PATCH] md: fix update super 1.0 on rdev size change markus
2021-11-15 9:47 ` Xiao Ni
2021-11-15 18:39 ` Markus Hochholdinger
2021-11-15 20:07 ` Wol
2021-11-16 8:35 ` Xiao Ni
2021-11-16 7:53 ` Xiao Ni
2021-11-16 9:28 ` Markus Hochholdinger
2021-11-16 16:41 ` Wols Lists
2021-11-16 8:36 ` Xiao Ni
2021-11-16 9:24 ` Paul Menzel
2021-11-16 9:44 ` Markus Hochholdinger
2021-11-16 9:52 ` Paul Menzel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f08f5e72-dcf4-7f89-21eb-e293b3db0dbf@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=Markus@hochholdinger.net \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox