public inbox for linux-raid@vger.kernel.org
 help / color / mirror / Atom feed
From: Guoqing Jiang <guoqing.jiang@linux.dev>
To: kernel test robot <lkp@intel.com>, axboe@kernel.dk
Cc: kbuild-all@lists.01.org, song@kernel.org, hch@infradead.org,
	linux-raid@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH V3] raid1: ensure write behind bio has less than BIO_MAX_VECS sectors
Date: Tue, 24 Aug 2021 08:43:18 +0800	[thread overview]
Message-ID: <f9748b7c-2c3f-ce4e-66a0-46c126c6b7dd@linux.dev> (raw)
In-Reply-To: <202108232012.No5kysqW-lkp@intel.com>

Hi,

Thanks for the report!

On 8/23/21 8:19 PM, kernel test robot wrote:
> Hi Guoqing,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on song-md/md-next]
> [also build test ERROR on v5.14-rc7 next-20210820]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url:    https://github.com/0day-ci/linux/commits/Guoqing-Jiang/raid1-ensure-write-behind-bio-has-less-than-BIO_MAX_VECS-sectors/20210823-154653
> base:   git://git.kernel.org/pub/scm/linux/kernel/git/song/md.git md-next
> config: sh-allmodconfig (attached as .config)
> compiler: sh4-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          # https://github.com/0day-ci/linux/commit/302a06a55fac4a9fb10f57dc96f6a618f3e853b4
>          git remote add linux-review https://github.com/0day-ci/linux
>          git fetch --no-tags linux-review Guoqing-Jiang/raid1-ensure-write-behind-bio-has-less-than-BIO_MAX_VECS-sectors/20210823-154653
>          git checkout 302a06a55fac4a9fb10f57dc96f6a618f3e853b4
>          # save the attached .config to linux build tree
>          mkdir build_dir
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash drivers/md/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
>     drivers/md/raid1.c: In function 'raid1_write_request':
>>> drivers/md/raid1.c:1393:44: error: 'mirror' undeclared (first use in this function); did you mean 'md_error'?
>      1393 |                 if (test_bit(WriteMostly, &mirror->rdev->flags))
>           |                                            ^~~~~~
>           |                                            md_error

Oops, will fix it.

> drivers/md/raid1.c:1477:52: error: 'PAGE_SECTORS' undeclared (first use in this function)
>      1477 |                                     BIO_MAX_VECS * PAGE_SECTORS);
>           |                                                    ^~~~~~~~~~~~

This patch is supposed to be merged by block tree due to dependency.

Thanks,
Guoqing

      reply	other threads:[~2021-08-24  0:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-23  7:45 [PATCH V3] raid1: ensure write behind bio has less than BIO_MAX_VECS sectors Guoqing Jiang
2021-08-23  7:49 ` Christoph Hellwig
2021-08-23 12:19 ` kernel test robot
2021-08-24  0:43   ` Guoqing Jiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9748b7c-2c3f-ce4e-66a0-46c126c6b7dd@linux.dev \
    --to=guoqing.jiang@linux.dev \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox