From: "Francois Barre" <francois.barre@gmail.com>
To: Neil Brown <neilb@suse.de>
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: Re: Neil, where are your Patches !
Date: Sat, 18 Mar 2006 10:31:53 +0100 [thread overview]
Message-ID: <fd8d0180603180131k517bc899y@mail.gmail.com> (raw)
In-Reply-To: <fd8d0180603170430r5cf8883dg@mail.gmail.com>
> > Ok, look again, under
> > http://cgi.cse.unsw.edu.au/~neilb/patches/linux-devel/
> >
Early comments :
I tested with patch-all-2006-03-17-10 on top of 2.6.16-rc6-mm1.
I had two compilation issues :
* in include/linux/raid/md_k.h, external is not defined in mddev_s. I
supposed it was an int.
* in drivers/raid/md.c and include/linux/raid/md.h, md_do_sync is
confused, being declared static, but used in other places, like
raid5.c. I supposed it shall be declared non-static.
With these 2 modifications, compilation is ok.
Raid5 resize testing :
I tried using it with 4 loop devices, creating a 3 10Mb raid5 and adding a 4th.
- mdadm -C -n 3 -l 5 /dev/md1 /dev/loop[123] : no problem
- mdadm -a /dev/md1 /dev/loop4 : loop4 is a spare
- mdadm -G -n 4 /dev/md1 returns error, but nothing happens : the 4th
is not added, and stays as a spare. md1 is still accessible, no
problem about that.
I'll try of course to investigate more...
Regards,
F.-E.B.
next prev parent reply other threads:[~2006-03-18 9:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-15 13:10 Neil, where are your Patches ! Francois Barre
2006-03-16 23:11 ` Neil Brown
2006-03-17 11:10 ` Neil Brown
2006-03-17 12:30 ` Francois Barre
2006-03-18 9:31 ` Francois Barre [this message]
2006-03-20 3:54 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd8d0180603180131k517bc899y@mail.gmail.com \
--to=francois.barre@gmail.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).