From: Andi Kleen <ak@muc.de>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-raid@vger.kernel.org, justin_gibbs@adaptec.com,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: "Enhanced" MD code avaible for review
Date: Thu, 18 Mar 2004 02:33:17 +0100 [thread overview]
Message-ID: <m3wu5jey76.fsf@averell.firstfloor.org> (raw)
In-Reply-To: <1AOTW-4Vx-5@gated-at.bofh.it> (Jeff Garzik's message of "Wed, 17 Mar 2004 20:30:12 +0100")
Jeff Garzik <jgarzik@pobox.com> writes:
>
> ioctl's are a pain for 32->64-bit translation layers. Using a
> read/write interface allows one to create an interface that requires
> no translation layer -- a big deal for AMD64 and IA32e processors
> moving forward -- and it also gives one a lot more control over the
> interface.
Sorry, Jeff, but that's just not true. While ioctls need an additional
entry in the conversion table, they can at least easily get an
translation handler if needed. When they are correctly designed you
just need a single line to enable pass through the emulation.
If you don't want to add that line to the generic compat_ioctl.h
file you can also do it in your driver.
read/write has the big disadvantage that if someone gets the emulation
wrong (and that happens regularly) it is near impossible to add an
emulation handler then, because there is no good way to hook
into the read/write paths.
There may be valid reasons to go for read/write, but 32bit emulation
is not one of them. In fact from the emulation perspective read/write
should be avoided.
-Andi
next parent reply other threads:[~2004-03-18 1:33 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1AOTW-4Vx-7@gated-at.bofh.it>
[not found] ` <1AOTW-4Vx-5@gated-at.bofh.it>
2004-03-18 1:33 ` Andi Kleen [this message]
2004-03-18 2:00 ` "Enhanced" MD code avaible for review Jeff Garzik
2004-03-20 9:58 ` Jamie Lokier
2004-03-19 20:19 Justin T. Gibbs
2004-03-23 5:05 ` Neil Brown
2004-03-23 6:23 ` Justin T. Gibbs
2004-03-24 2:26 ` Neil Brown
2004-03-24 19:09 ` Matt Domsch
2004-03-25 2:21 ` Jeff Garzik
2004-03-25 18:00 ` Kevin Corry
2004-03-25 18:42 ` Jeff Garzik
2004-03-25 18:48 ` Jeff Garzik
2004-03-25 23:46 ` Justin T. Gibbs
2004-03-26 0:01 ` Jeff Garzik
2004-03-26 0:10 ` Justin T. Gibbs
2004-03-26 0:14 ` Jeff Garzik
2004-03-25 22:04 ` Lars Marowsky-Bree
2004-03-26 19:19 ` Kevin Corry
2004-03-31 17:07 ` Randy.Dunlap
2004-03-25 23:35 ` Justin T. Gibbs
2004-03-26 0:13 ` Jeff Garzik
2004-03-26 17:43 ` Justin T. Gibbs
2004-03-28 0:06 ` Lincoln Dale
2004-03-30 17:54 ` Justin T. Gibbs
2004-03-28 0:30 ` Jeff Garzik
2004-03-26 19:15 ` Kevin Corry
2004-03-26 20:45 ` Justin T. Gibbs
2004-03-27 15:39 ` Kevin Corry
2004-03-30 17:03 ` Justin T. Gibbs
2004-03-30 17:15 ` Jeff Garzik
2004-03-30 17:35 ` Justin T. Gibbs
2004-03-30 17:46 ` Jeff Garzik
2004-03-30 18:04 ` Justin T. Gibbs
2004-03-30 21:47 ` Jeff Garzik
2004-03-30 22:12 ` Justin T. Gibbs
2004-03-30 22:34 ` Jeff Garzik
2004-03-30 18:11 ` Bartlomiej Zolnierkiewicz
2004-03-25 22:59 ` Justin T. Gibbs
2004-03-25 23:44 ` Lars Marowsky-Bree
2004-03-26 0:03 ` Justin T. Gibbs
-- strict thread matches above, loose matches on Subject: below --
2004-03-17 18:14 Justin T. Gibbs
2004-03-17 19:18 ` Jeff Garzik
2004-03-17 19:32 ` Christoph Hellwig
2004-03-17 20:02 ` Jeff Garzik
2004-03-17 21:18 ` Scott Long
2004-03-17 21:35 ` Jeff Garzik
2004-03-17 21:45 ` Bartlomiej Zolnierkiewicz
2004-03-18 0:23 ` Scott Long
2004-03-18 1:55 ` Bartlomiej Zolnierkiewicz
2004-03-18 6:38 ` Stefan Smietanowski
2004-03-20 13:07 ` Arjan van de Ven
2004-03-21 23:42 ` Scott Long
2004-03-22 9:05 ` Arjan van de Ven
2004-03-22 21:59 ` Scott Long
2004-03-23 6:48 ` Arjan van de Ven
2004-03-18 1:56 ` viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3wu5jey76.fsf@averell.firstfloor.org \
--to=ak@muc.de \
--cc=jgarzik@pobox.com \
--cc=justin_gibbs@adaptec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).