From: sashiko-bot@kernel.org
To: "Eric Biggers" <ebiggers@kernel.org>
Cc: linux-raid@vger.kernel.org, yukuai@fygo.io
Subject: Re: [PATCH 6.12] raid6: add missing vzeroupper to AVX-512 code
Date: Sat, 07 Nov 2026 20:19:09 +0000 [thread overview]
Message-ID: <sashiko-outbox-203264@kernel.org> (raw)
In-Reply-To: <20261107200913.103158-1-ebiggers@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] raid6: missing Fixes trailer for AVX-512 xor_syndrome commit
694dda62d286
--
commit 369a70502fe6ce19affa3189f8d493476e955e10
Author: Eric Biggers <ebiggers@kernel.org>
> raid6: add missing vzeroupper to AVX-512 code
>
> commit b82cf9e49c1be7cf1fd8e1bd806b0cdd25ab8127 upstream.
>
> Since the AVX-512 optimized RAID6 code uses ZMM registers, execute
> vzeroupper before returning from it. This is needed to avoid degrading
> the performance of any later SSE code that may happen to be executed.
>
> Link: https://lore.kernel.org/20260831212316.213896-1-ebiggers@kernel.org
> Fixes: e0a491c12968 ("lib/raid6: Add AVX512 optimized gen_syndrome functions")
> Fixes: 13c520b2993c ("lib/raid6: Add AVX512 optimized recovery functions")
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: <stable@vger.kernel.org>
[Severity: Low]
In addition to the gen_syndrome and recovery functions, this patch adds
vzeroupper to raid6_avx5121_xor_syndrome(), raid6_avx5122_xor_syndrome(),
and raid6_avx5124_xor_syndrome(). Should this also include:
Fixes: 694dda62d286 ("lib/raid6: Add AVX512 optimized xor_syndrome functions")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261107200913.103158-1-ebiggers@kernel.org?part=1
prev parent reply other threads:[~2026-11-07 20:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 20:09 [PATCH 6.12] raid6: add missing vzeroupper to AVX-512 code Eric Biggers
2026-11-07 20:19 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-203264@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=ebiggers@kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=yukuai@fygo.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox