From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: NeilBrown <neilb@suse.com>,
Sebastian Parschauer <sebastian.riemer@profitbricks.com>,
linux-raid <linux-raid@vger.kernel.org>,
Shaohua Li <shli@kernel.org>,
Brassow Jonathan <jbrassow@redhat.com>,
Artur Paszkiewicz <artur.paszkiewicz@intel.com>,
systemd-devel@freedesktop.org
Subject: Re: [PATCH 2/2] Manage: Inform udev about device removal when stopping
Date: Wed, 17 Feb 2016 08:06:28 -0500 [thread overview]
Message-ID: <wrfj1t8ba3l7.fsf@redhat.com> (raw)
In-Reply-To: <56C41B3A.90902@suse.de> (Hannes Reinecke's message of "Wed, 17 Feb 2016 08:03:22 +0100")
Hannes Reinecke <hare@suse.de> writes:
> On 02/16/2016 09:46 PM, NeilBrown wrote:
>> On Wed, Feb 17 2016, Jes Sorensen wrote:
>>>
>>> I am totally fine with this, however we should make mdadm
>>> fail if run against a pre-2.6.28 kernel then.
>>>
>>> Cheers, Jes
>>
>> I would suggest protecting the
>>
>> if (fd >= 0) ioctl(fd, BLKRRPART, 0); if (mdi)
>> sysfs_uevent(mdi, "change");
>>
>> code with
>>
>> if (get_linux_version() < 2006028)
>>
>> That should be completely safe - 2.6.28 and later do this (if
>> needed).
>>
> +1.
>
> Yes, this is the best solution.
Sebastian indicates it only works if the kernel patch he submitted is
applied too - should we tweak the mdadm version check to match the next
upstream kernel, or stick with it as is here?
Jes
next prev parent reply other threads:[~2016-02-17 13:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 14:44 [PATCH 0/2] md/mdadm: Inform udev about device removal when stopping Sebastian Parschauer
2016-02-16 14:44 ` [PATCH 1/2] md: " Sebastian Parschauer
2016-02-16 20:05 ` Shaohua Li
2016-02-16 20:43 ` NeilBrown
2016-02-17 11:24 ` Sebastian Parschauer
2016-02-17 22:57 ` NeilBrown
2016-02-16 14:44 ` [PATCH 2/2] Manage: " Sebastian Parschauer
2016-02-16 17:41 ` Jes Sorensen
2016-02-16 18:03 ` Sebastian Parschauer
2016-02-16 18:40 ` Hannes Reinecke
2016-02-16 18:52 ` Jes Sorensen
2016-02-16 20:46 ` NeilBrown
2016-02-16 22:02 ` Jes Sorensen
2016-02-17 10:31 ` Sebastian Parschauer
2016-02-17 7:03 ` Hannes Reinecke
2016-02-17 13:06 ` Jes Sorensen [this message]
2016-02-17 13:16 ` Sebastian Parschauer
2016-02-17 17:33 ` Jes Sorensen
-- strict thread matches above, loose matches on Subject: below --
2016-02-16 15:47 Hannes Reinecke
2016-02-16 16:58 ` Sebastian Parschauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfj1t8ba3l7.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=artur.paszkiewicz@intel.com \
--cc=hare@suse.de \
--cc=jbrassow@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=sebastian.riemer@profitbricks.com \
--cc=shli@kernel.org \
--cc=systemd-devel@freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).